http: add redirect conflict

This conflict is added, since the migration here would not preserve
behaviour.

Change-Id: I24b70f383fdaa68e07845dfca64cabe79e31e13e

Author: SoloJacobs

cmk/update_config/http/conflicts.py

@@ -159,7 +159,7 @@ def detect_conflicts(rule_value: Mapping[str, object]) -> Conflict | MigratableV
                 mode_fields=["method", "post_data"],
             )
         try:
-            _migrate_expect_response(mode.expect_response or [])
+            migrated_expect_response = _migrate_expect_response(mode.expect_response or [])
         except ValueError:
             return Conflict(
                 type_="only_status_codes_allowed",
@@ -171,6 +171,11 @@ def detect_conflicts(rule_value: Mapping[str, object]) -> Conflict | MigratableV
                 mode_fields=["ssl"],
                 disable_sni=True,
             )
+        if migrated_expect_response and mode.onredirect in ["follow", "sticky", "stickyport"]:
+            return Conflict(
+                type_="v1_checks_redirect_response",
+                mode_fields=["onredirect", "expect_response"],
+            )
     elif value.disable_sni:  # Cert mode is always https
         return Conflict(
             type_="cant_disable_sni_with_https",

tests/unit/cmk/update_config/http/test_migrate.py

@@ -730,6 +730,18 @@
 
 EXAMPLE_90: Mapping[str, object] = {}
 
+EXAMPLE_91: Mapping[str, object] = {
+    "name": "authorization",
+    "host": HOST_1,
+    "mode": (
+        "url",
+        {
+            "expect_response": ["302"],
+            "onredirect": "stickyport",
+        },
+    ),
+}
+
 
 @pytest.mark.parametrize(
     "rule_value",
@@ -1167,6 +1179,13 @@ def test_migrate_ssl(rule_value: Mapping[str, object], expected: str) -> None:
                 cant_load=True,
             ),
         ),
+        (
+            EXAMPLE_91,
+            Conflict(
+                type_="v1_checks_redirect_response",
+                mode_fields=["onredirect", "expect_response"],
+            ),
+        ),
     ],
 )
 def test_detect_conflicts(rule_value: Mapping[str, object], conflict: Conflict) -> None: