Skip to content

Commit c92f483

Browse files
committed
Successful build with feature SQS.resultCurves3d
1 parent c4f3048 commit c92f483

File tree

2 files changed

+13
-12
lines changed

2 files changed

+13
-12
lines changed

QuadHypComponent.cs

Lines changed: 7 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -135,11 +135,14 @@ protected override void SolveInstance(IGH_DataAccess DA)
135135
int id = edges.FindIndex(x => x.GetHashCode().Equals(edge.GetHashCode()));
136136
indices.Add(id);
137137
}
138+
138139

140+
// .Net C# additional checks required to avoid negative indexing
141+
// GH C# is fine with negative indexing
139142
BrepEdge bottomEdge = edges[indices[0]];
140143
BrepEdge topEdge = edges[indices[3]];
141144
BrepEdge rightEdge = edges[(indices[0] - 1)>=0? (indices[0] - 1): (indices.Count - 1)];
142-
BrepEdge leftEdge = edges[indices[3] - 1];
145+
BrepEdge leftEdge = edges[(indices[3] - 1)>=0? (indices[3] - 1): (indices.Count - 1)];
143146

144147
List<NurbsCurve> trimCurves = new List<NurbsCurve>(){
145148
topEdge.ToNurbsCurve(),
@@ -190,14 +193,14 @@ protected override void SolveInstance(IGH_DataAccess DA)
190193
SQS.AddTrim(trimCurve);
191194
var A = SQS.GetAllTriangulatedPolygons();
192195

193-
//SQS.CalculateTrims(true, ref SS);
196+
SQS.CalculateTrims(true);
194197

195-
//B = SQS.resultCurves2d;
198+
var B = SQS.resultCurves2d;
196199

197200

198201

199202

200-
DA.SetDataList(1, A);
203+
DA.SetDataList(1, B);
201204

202205

203206

SurfaceQuadSubdivision.cs

Lines changed: 6 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -23,8 +23,8 @@ public class SurfaceQuadSubdivision
2323

2424
public NurbsCurve TrimCurve3d;
2525
public NurbsCurve TrimCurve2d;
26-
public List<NurbsCurve> resultCurves2d;
27-
public List<NurbsCurve> resultCurves3d;
26+
public List<NurbsCurve> resultCurves2d = new List<NurbsCurve>();
27+
public List<NurbsCurve> resultCurves3d = new List<NurbsCurve>();
2828

2929
public SurfaceQuadSubdivision(NurbsSurface _srf, int _UCount, int _VCount)
3030
{
@@ -389,7 +389,7 @@ public List<NurbsSurface> GetAllFacetedSurfaces3D()
389389
}
390390

391391

392-
public void CalculateTrims(bool coarse, ref object S)
392+
public void CalculateTrims(bool coarse)
393393
{
394394
PolygonPolygonAnalyticalIntersection2d PPI2;
395395

@@ -400,15 +400,13 @@ public void CalculateTrims(bool coarse, ref object S)
400400

401401
if (PPI2.hasResult)
402402
{
403-
try
404-
{
403+
405404

406405
resultCurves2d.Add(PPI2.resultCurve);
407406

408-
}
409-
catch (Exception e) { }
407+
410408
}
411-
S = 1;
409+
412410
}
413411
resultCurves3d = UV2XYZ(resultCurves2d);
414412

0 commit comments

Comments
 (0)