-
Notifications
You must be signed in to change notification settings - Fork 498
/
Copy pathprefer-assert-instance-of.ts
76 lines (68 loc) · 2.76 KB
/
prefer-assert-instance-of.ts
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
// Copyright 2024 The Chromium Authors. All rights reserved.
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
import {createRule} from './utils/ruleCreator.ts';
const FALSY_ASSERTIONS = new Set(['isFalse', 'isNotOk', 'isNotTrue', 'notOk']);
const TRUTHY_ASSERTIONS = new Set(['isNotFalse', 'isOk', 'isTrue', 'ok']);
export default createRule({
name: 'prefer-assert-instance-of',
meta: {
type: 'suggestion',
docs: {
description: 'Prefer `assert.instanceOf` to assert that a value is an instance of a class',
category: 'Best Practices',
},
messages: {
useAssertInstanceOf: 'Use `assert.instanceOf` to assert that a value is an instance of a class',
useAssertNotInstanceOf: 'Use `assert.notInstanceOf` to assert that a value is not an instance of a class',
},
fixable: 'code',
schema: [], // no options
},
defaultOptions: [],
create: function(context) {
function isTruthyAssertion(calleeNode) {
if (calleeNode.type === 'Identifier' && calleeNode.name === 'assert') {
return true;
}
return calleeNode.type === 'MemberExpression' && calleeNode.object.type === 'Identifier' &&
calleeNode.object.name === 'assert' && calleeNode.property.type === 'Identifier' &&
TRUTHY_ASSERTIONS.has(calleeNode.property.name);
}
function isFalsyAssertion(calleeNode) {
return calleeNode.type === 'MemberExpression' && calleeNode.object.type === 'Identifier' &&
calleeNode.object.name === 'assert' && calleeNode.property.type === 'Identifier' &&
FALSY_ASSERTIONS.has(calleeNode.property.name);
}
function isInstanceofExpression(argumentNode) {
return argumentNode.type === 'BinaryExpression' && argumentNode.operator === 'instanceof';
}
function reportError(node, calleeText, messageId) {
context.report({
node,
messageId,
fix(fixer) {
const {sourceCode} = context;
const calleeNode = node.callee;
const [argumentNode] = node.arguments;
const argumentText = `${sourceCode.getText(argumentNode.left)}, ${sourceCode.getText(argumentNode.right)}`;
return [
fixer.replaceText(calleeNode, calleeText),
fixer.replaceText(argumentNode, argumentText),
];
}
});
}
return {
CallExpression(node) {
if (node.arguments.length >= 1 && isInstanceofExpression(node.arguments[0])) {
if (isTruthyAssertion(node.callee)) {
reportError(node, 'assert.instanceOf', 'useAssertInstanceOf');
} else if (isFalsyAssertion(node.callee)) {
reportError(node, 'assert.notInstanceOf', 'useAssertNotInstanceOf');
}
}
}
};
},
});