-
Notifications
You must be signed in to change notification settings - Fork 498
/
Copy pathprefer-assert-length-of.ts
69 lines (62 loc) · 2.46 KB
/
prefer-assert-length-of.ts
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
// Copyright 2024 The Chromium Authors. All rights reserved.
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
import {createRule} from './utils/ruleCreator.ts';
const EQUALITY_ASSERTIONS = new Set(['deepEqual', 'deepStrictEqual', 'equal', 'strictEqual']);
export default createRule({
name: 'prefer-assert-length-of',
meta: {
type: 'suggestion',
docs: {
description: 'Prefer `assert.lengthOf` to check `length` of an array-like.',
category: 'Best Practices',
},
messages: {
useAssertLengthOf: 'Use `assert.lengthOf` to check `length` of an array-like',
},
fixable: 'code',
schema: [], // no options
},
defaultOptions: [],
create: function(context) {
function isAssertEquality(calleeNode) {
return calleeNode.type === 'MemberExpression' && calleeNode.object.type === 'Identifier' &&
calleeNode.object.name === 'assert' && calleeNode.property.type === 'Identifier' &&
EQUALITY_ASSERTIONS.has(calleeNode.property.name);
}
function isLengthProperty(argumentNode) {
return argumentNode.type === 'MemberExpression' && argumentNode.property.type === 'Identifier' &&
argumentNode.property.name === 'length';
}
function isNumberLiteral(argumentNode) {
return argumentNode.type === 'Literal' && typeof argumentNode.value === 'number';
}
function reportError(node) {
context.report({
node,
messageId: 'useAssertLengthOf',
fix(fixer) {
const {sourceCode} = context;
const calleeNode = node.callee;
const [firstArgNode, secondArgNode] = node.arguments;
const objectNode = (isLengthProperty(firstArgNode) ? firstArgNode : secondArgNode).object;
const lengthNode = isNumberLiteral(firstArgNode) ? firstArgNode : secondArgNode;
return [
fixer.replaceText(calleeNode, 'assert.lengthOf'),
fixer.replaceText(firstArgNode, sourceCode.getText(objectNode)),
fixer.replaceText(secondArgNode, sourceCode.getText(lengthNode)),
];
}
});
}
return {
CallExpression(node) {
if (isAssertEquality(node.callee) && node.arguments.length >= 2 &&
(isLengthProperty(node.arguments[0]) && isNumberLiteral(node.arguments[1]) ||
(isNumberLiteral(node.arguments[0]) && isLengthProperty(node.arguments[1])))) {
reportError(node);
}
}
};
},
});