Skip to content

Commit b2de95f

Browse files
Alesandro OrtizDevtools-frontend LUCI CQ
Alesandro Ortiz
authored and
Devtools-frontend LUCI CQ
committed
Check URL scheme in InspectorFrontendHost.openInNewTab()
Fixed: 402791076 Change-Id: I40651dd32e797a67cb7e46c9a060cfcc6fb6d50b Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6353071 Reviewed-by: Danil Somsikov <[email protected]> Reviewed-by: Philip Pfaffe <[email protected]> Commit-Queue: Alesandro Ortiz <[email protected]>
1 parent 07c77aa commit b2de95f

File tree

2 files changed

+4
-0
lines changed

2 files changed

+4
-0
lines changed

AUTHORS

+1
Original file line numberDiff line numberDiff line change
@@ -13,6 +13,7 @@
1313
# BEGIN individuals section.
1414
AbdAlRahman Gad <[email protected]>
1515
Ajay Panthagani <[email protected]>
16+
Alesandro Ortiz <[email protected]>
1617
Alexander Stammbach <[email protected]>
1718
Alexey Rodionov <[email protected]>
1819
Ankit Mishra <[email protected]>

front_end/core/host/InspectorFrontendHost.ts

+3
Original file line numberDiff line numberDiff line change
@@ -187,6 +187,9 @@ export class InspectorFrontendHostStub implements InspectorFrontendHostAPI {
187187
}
188188

189189
openInNewTab(url: Platform.DevToolsPath.UrlString): void {
190+
if (Common.ParsedURL.schemeIs(url, 'javascript:')) {
191+
return;
192+
}
190193
window.open(url, '_blank');
191194
}
192195

0 commit comments

Comments
 (0)