-
Notifications
You must be signed in to change notification settings - Fork 40
Implement parallel support for ODBC and OLE DB #45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
For all advanced statements (like We should do this implicitly in EFCore.Jet, so that nobody has to worry about it. In case anybody complains about it in the future for some reason, we can always add an option to disable it. I also had to switch the identifier character from |
I am going to add support for automatic provider/driver detection, so that just specifying a database name will use the newest installed database provider/driver. We can get rid of |
In the future, we should consider refactoring the ODBC/OLE DB conditionals into their own self-contained classes, and ship them as |
|
I looked at the code. There are still square brackets around (at least in RemoveBrackets method). Probably we could just find [ and replace (or, better, cover with tests because as far as I can understand all the tests work fine now). |
Thanks, I missed a couple of those! I checked the
They should all be running, but we are far away from having all the test green. |
@lauxjpn WHAT A HUGE WORK!!! Great!!! |
When you think that everything is stable enough tell me something because I'd like to help you on test fixing. |
The code should be stable enough after merging #47 (which I am going to do in a couple of hours). We currently have 1110 green, 788 red and 100 skipped tests from the |
Continues the discussion around this feature from #43.
The text was updated successfully, but these errors were encountered: