[ignore] Added namespace and collection to see also note in docs of l4l7 device modules

Author: shrsr

plugins/modules/aci_l4l7_concrete_device.py

@@ -52,11 +52,11 @@
 - cisco.aci.aci
 - cisco.aci.annotation
 notes:
-- The I(tenant) and I(device) must exist before using this module in your playbook.
+- The I(tenant) and I(logical_device) must exist before using this module in your playbook.
   The M(cisco.aci.aci_tenant) and M(cisco.aci.aci_l4l7_device) modules can be used for this.
 seealso:
-- module: aci_tenant
-- module: aci_l4l7_device
+- module: cisco.aci.aci_tenant
+- module: cisco.aci.aci_l4l7_device
 - name: APIC Management Information Model reference
   description: More information about the internal APIC class B(vns:CDev)
   link: https://developer.cisco.com/docs/apic-mim-ref/

plugins/modules/aci_l4l7_concrete_interface.py

@@ -70,11 +70,11 @@
 - cisco.aci.aci
 - cisco.aci.annotation
 notes:
-- The I(tenant), I(device) and I(concrete_device) must exist before using this module in your playbook.
+- The I(tenant), I(logical_device) and I(concrete_device) must exist before using this module in your playbook.
   The M(cisco.aci.aci_tenant), M(cisco.aci.aci_l4l7_device) and M(cisco.aci.aci_l4l7_concrete_device) modules can be used for this.
 seealso:
-- module: aci_l4l7_device
-- module: aci_l4l7_concrete_device
+- module: cisco.aci.aci_l4l7_device
+- module: cisco.aci.aci_l4l7_concrete_device
 - name: APIC Management Information Model reference
   description: More information about the internal APIC class B(vns:CIf)
   link: https://developer.cisco.com/docs/apic-mim-ref/

plugins/modules/aci_l4l7_concrete_interface_attachment.py

@@ -52,15 +52,15 @@
 - cisco.aci.aci
 - cisco.aci.annotation
 notes:
-- The I(tenant), I(device), I(logical_interface) and I(concrete_device) must exist before using this module in your playbook.
+- The I(tenant), I(logical_device), I(logical_interface) and I(concrete_device) must exist before using this module in your playbook.
   The M(cisco.aci.aci_tenant), M(cisco.aci.aci_l4l7_device), M(cisco.aci.aci_l4l7_logical_interface)
   and M(cisco.aci.aci_l4l7_concrete_device) modules can be used for this.
 seealso:
-- module: aci_tenant
-- module: aci_l4l7_device
-- module: aci_l4l7_logical_interface
-- module: aci_l4l7_concrete_device
-- module: aci_l4l7_concrete_interface
+- module: cisco.aci.aci_tenant
+- module: cisco.aci.aci_l4l7_device
+- module: cisco.aci.aci_l4l7_logical_interface
+- module: cisco.aci.aci_l4l7_concrete_device
+- module: cisco.aci.aci_l4l7_concrete_interface
 - name: APIC Management Information Model reference
   description: More information about the internal APIC class B(vns:RsCIfAttN)
   link: https://developer.cisco.com/docs/apic-mim-ref/

plugins/modules/aci_l4l7_device.py

@@ -76,6 +76,12 @@
     - The domain to bind to the device.
     - The type of domain is controlled by the device_type setting.
     type: str
+  active_active_mode:
+    description:
+    - The active active mode on the device.
+    - This is only applicable when C(function_type="l1") or C(function_type="l2").
+    - The APIC defaults to C(false) when unset during creation.
+    type: bool
   state:
     description:
     - Use C(present) or C(absent) for adding or removing.
@@ -90,7 +96,7 @@
 - The I(tenant) must exist before using this module in your playbook.
   The M(cisco.aci.aci_tenant) modules can be used for this.
 seealso:
-- module: aci_tenant
+- module: cisco.aci.aci_tenant
 - name: APIC Management Information Model reference
   description: More information about the internal APIC class B(vns:LDevVip)
   link: https://developer.cisco.com/docs/apic-mim-ref/
@@ -275,6 +281,7 @@ def main():
         service_type=dict(type="str", aliases=["svc_type"], choices=["adc", "fw", "others"]),
         trunking=dict(type="bool"),
         domain=dict(type="str"),
+        active_active_mode=dict(type="bool"),
     )
 
     module = AnsibleModule(
@@ -299,6 +306,7 @@ def main():
     service_type = module.params.get("service_type")
     trunking = aci.boolean(module.params.get("trunking"))
     domain = module.params.get("domain")
+    active_active_mode = aci.boolean(module.params.get("active_active_mode"))
 
     aci.construct_url(
         root_class=dict(
@@ -339,6 +347,7 @@ def main():
                 promMode=promiscuous_mode,
                 svcType=service_type.upper(),
                 trunking=trunking,
+                activeActive=active_active_mode,
             ),
             child_configs=child_configs,
         )

plugins/modules/aci_l4l7_logical_interface.py

@@ -38,6 +38,11 @@
     - The encapsulation of the Logical Interface.
     - It requires the VLAN to be prepended, for example, 'vlan-987'.
     type: str
+  enhanced_lag_policy:
+    description:
+    - Name of the VMM Domain Enhanced Lag Policy.
+    type: str
+    aliases: [ lag_policy ]
   state:
     description:
     - Use C(present) or C(absent) for adding or removing.
@@ -49,10 +54,11 @@
 - cisco.aci.aci
 - cisco.aci.annotation
 notes:
-- The I(tenant) and I(device) must exist before using this module in your playbook.
+- The I(tenant) and I(logical_device) must exist before using this module in your playbook.
   The M(cisco.aci.aci_tenant) and M(cisco.aci.aci_l4l7_device) modules can be used for this.
 seealso:
-- module: aci_l4l7_device
+- module: cisco.aci.aci_tenant
+- module: cisco.aci.aci_l4l7_device
 - name: APIC Management Information Model reference
   description: More information about the internal APIC class B(vns:LIf)
   link: https://developer.cisco.com/docs/apic-mim-ref/
@@ -226,6 +232,7 @@ def main():
         logical_interface=dict(type="str", aliases=["name"]),
         state=dict(type="str", default="present", choices=["absent", "present", "query"]),
         encap=dict(type="str"),
+        enhanced_lag_policy=dict(type="str", aliases=["lag_policy"]),
     )
 
     module = AnsibleModule(
@@ -242,6 +249,7 @@ def main():
     logical_device = module.params.get("logical_device")
     logical_interface = module.params.get("logical_interface")
     encap = module.params.get("encap")
+    enhanced_lag_policy = module.params.get("enhanced_lag_policy")
 
     aci = ACIModule(module)
 
@@ -271,7 +279,7 @@ def main():
     if state == "present":
         aci.payload(
             aci_class="vnsLIf",
-            class_config=dict(name=logical_interface, encap=encap),
+            class_config=dict(name=logical_interface, encap=encap, lagPolicyName=enhanced_lag_policy),
         )
         aci.get_diff(aci_class="vnsLIf")
 

tests/integration/targets/aci_l4l7_device/tasks/main.yml

@@ -206,6 +206,30 @@
     that:
     - update_l4l7_device.current.0.vnsLDevVip.children.0.vnsRsALDevToPhysDomP.attributes.tDn == "uni/phys-ansible_phys_dom"
 
+- name: Create another L4-L7 device to test active active mode
+  cisco.aci.aci_l4l7_device:
+    <<: *aci_info
+    tenant: ansible_tenant
+    device: ansible_device2
+    domain: ansible_phys_dom
+    func_type: l1
+    context_aware: multi
+    managed: false
+    dev_type: physical
+    svc_type: others
+    trunking: true
+    prom_mode: false
+    active_active_mode: true
+    state: present
+  register: another_l4l7_device_active
+
+- name: Verify domain binding object
+  ansible.builtin.assert:
+    that:
+    - another_l4l7_device_active is changed
+    - another_l4l7_device_active.current.0.vnsLDevVip.attributes.funcType == "L1"
+    - another_l4l7_device_active.current.0.vnsLDevVip.attributes.activeActive == "yes"
+
 # QUERY DEVICE
 - name: Query L4-L7 Device
   cisco.aci.aci_l4l7_device:
@@ -240,7 +264,7 @@
   ansible.builtin.assert:
     that:
       - query_l4l7_device_all is not changed
-      - query_l4l7_device_all.current | length >= 2
+      - query_l4l7_device_all.current | length >= 3
       - "'uni/tn-ansible_tenant/lDevVip-ansible_device' in query_l4l7_device_all.current | map(attribute='vnsLDevVip.attributes.dn') | list"
       - "'uni/tn-ansible_tenant/lDevVip-ansible_virt_device' in query_l4l7_device_all.current | map(attribute='vnsLDevVip.attributes.dn') | list"
 

tests/integration/targets/aci_l4l7_logical_interface/tasks/main.yml

@@ -35,6 +35,14 @@
     domain_type: phys
     state: absent
 
+- name: Remove ansible_vmm_domain if it already exists
+  cisco.aci.aci_domain:
+    <<: *aci_info
+    domain: ansible_vmm_dom
+    domain_type: vmm
+    vm_provider: vmware
+    state: absent
+
 # CREATE TENANT
 - name: Create ansible_tenant
   cisco.aci.aci_tenant:
@@ -50,6 +58,14 @@
     domain_type: phys
     state: present
 
+- name: Create ansible_vmm_domain
+  cisco.aci.aci_domain:
+    <<: *aci_info
+    domain: ansible_vmm_dom
+    domain_type: vmm
+    vm_provider: vmware
+    state: present
+
 # CREATE L4-L7 LOGICAL DEVICE
 - name: Create L4-L7 Device
   cisco.aci.aci_l4l7_device:
@@ -66,6 +82,21 @@
     prom_mode: true
     state: present
 
+- name: Create L4-L7 Virtual Device
+  cisco.aci.aci_l4l7_device:
+    <<: *aci_info
+    tenant: ansible_tenant
+    device: ansible_virt_device
+    domain: ansible_vmm_dom
+    func_type: go_to
+    context_aware: single
+    managed: false
+    dev_type: virtual
+    svc_type: adc
+    trunking: false
+    prom_mode: true
+    state: present
+
 # CREATE L4-L7 LOGICAL INTERFACE
 - name: Add Logical Interface in check mode
   cisco.aci.aci_l4l7_logical_interface: &l4l7_logical_interface
@@ -122,6 +153,48 @@
     - update_logical_interface.current.0.vnsLIf.attributes.name == "ansible_log_intf"
     - update_logical_interface.current.0.vnsLIf.attributes.encap == "vlan-988"
 
+# Test to verify enhanced_lag_policy
+- name: Create enhanced lag policy
+  cisco.aci.aci_rest:
+    <<: *aci_info
+    path: api/node/mo/uni/vmmp-VMware/dom-ansible_vmm_dom/vswitchpolcont.json
+    method: post
+    content: |
+      {
+        "vmmVSwitchPolicyCont": {
+          "attributes": {
+            "dn": "uni/vmmp-VMware/dom-ansible_vmm_dom/vswitchpolcont",
+            "status": "created,modified"
+          },
+          "children": [{
+                "lacpEnhancedLagPol": {
+                    "attributes": {
+                        "lbmode": "src-dst-ip",
+                        "mode": "active",
+                        "name": "enhanced",
+                        "numLinks": "2"
+                    }
+                }
+          }]
+        }
+      }
+
+- name: Add Logical Interface for virtual device
+  cisco.aci.aci_l4l7_logical_interface:
+    <<: *aci_info
+    tenant: ansible_tenant
+    device: ansible_virt_device
+    logical_interface: ansible_virt
+    lag_policy: enhanced
+    state: present
+  register: add_logical_interface_virtual
+
+- name: Verify Logical Interface Virtual
+  ansible.builtin.assert:
+    that:
+    - add_logical_interface_virtual is changed
+    - add_logical_interface_virtual.current.0.vnsLIf.attributes.lagPolicyName == "enhanced"
+
 # QUERY L4-L7 LOGICAL INTERFACE
 - name: Create a second L4-L7 Logical Interface for query all
   cisco.aci.aci_l4l7_logical_interface:
@@ -153,7 +226,7 @@
     - query_logical_interface is not changed
     - query_logical_interface.current.0.vnsLIf.attributes.dn == "uni/tn-ansible_tenant/lDevVip-ansible_device/lIf-ansible_log_intf"
     - query_logical_interface.current.0.vnsLIf.attributes.name == "ansible_log_intf"
-    - query_all.current | length >= 2
+    - query_all.current | length >= 3
     - "'uni/tn-ansible_tenant/lDevVip-ansible_device/lIf-ansible_log_intf' in query_all.current | map(attribute='vnsLIf.attributes.dn') | list"
     - "'uni/tn-ansible_tenant/lDevVip-ansible_device/lIf-ansible_log_int2' in query_all.current | map(attribute='vnsLIf.attributes.dn') | list"
     - query_logical_interface.current.0.vnsLIf.attributes.encap == "vlan-988"
@@ -205,3 +278,11 @@
     domain: ansible_phys_dom
     domain_type: phys
     state: absent
+
+- name: Remove ansible_vmm_domain if it already exists
+  cisco.aci.aci_domain:
+    <<: *aci_info
+    domain: ansible_vmm_dom
+    domain_type: vmm
+    vm_provider: vmware
+    state: absent