Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Audit: Contract Call Events #34

Open
lllwvlvwlll opened this issue Feb 17, 2022 · 0 comments
Open

Audit: Contract Call Events #34

lllwvlvwlll opened this issue Feb 17, 2022 · 0 comments

Comments

@lllwvlvwlll
Copy link
Member

This issue will evaluate the security of contract calls made by generators. Currently, we enable arbitrary contract calls as a feature of the generators, but this introduces the opportunity to spoof instances. For example, users wishing to whitelist the generator for a props contract instance will be unable to prevent users of this feature from hardcoding a fake instanceID.

The proposed resolution to this issue is to limit the contract call event by enforcing the passing of the generator's instanceID as the first parameter in the call. This would prevent users from spoofing instances at the expense of requiring an interfacing contract for any contracts which do not already support props instances (which all invoke using the instance ID as the first parameter).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant