Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Optimize Greedy Meshing #27

Open
ClarkThyLord opened this issue Dec 28, 2019 · 2 comments
Open

Optimize Greedy Meshing #27

ClarkThyLord opened this issue Dec 28, 2019 · 2 comments
Labels
help wanted Extra attention is needed

Comments

@ClarkThyLord
Copy link
Owner

Optimize the greedy meshing of VoxelObjects, such as VoxelMesh, right now it's iterative, maybe it can be optimized with a recursive method.
@ClarkThyLord ClarkThyLord added the help wanted Extra attention is needed label Dec 28, 2019
@ScorpionInc
Copy link
Contributor

Hmm would recursive actually be faster? I did a quick test and it seems to be slower. Not trying to sound like a downer or rude, but maybe there is a different method that could further speed up the processing but I don't think that this is it...
Code:
https://github.com/ScorpionInc/Godot-GDSandbox/blob/main/IterativeVsRecursiveTest.gd

@ClarkThyLord
Copy link
Owner Author

Hmm, you have a point, it's not always that recursion improves performance; I've implemented both the iterative and recursive method for greedy meshing, would be be good to run some benchmarks as you did. Either way, I'll look into exploring more options to improve performance 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ClarkThyLord @ScorpionInc