Skip to content

Conversation

@Maleclypse
Copy link
Member

Summary

None

Purpose of change

Adds 50lb bags of sugar and flour into the world.

Describe the solution

Add new bag, and two item groups using it.

Describe alternatives you've considered

None

Testing

Additional context

@github-actions github-actions bot added [JSON] Changes (can be) made in JSON Items: Food / Vitamins Comestibles and drinks Spawn Creatures, items, vehicles, locations appearing on map Items: Containers Things that hold other things json-styled JSON lint passed, label assigned by github actions astyled astyled PR, label is assigned by github actions labels Oct 25, 2025
@Maleclypse Maleclypse mentioned this pull request Oct 25, 2025
@akrieger
Copy link
Member

([slow] ~starting_items)=> (continued from above) ERROR : src/item_factory.cpp:2759 [void Item_factory::check_definitions() const] warnings for type bag_paper_powder_50lb:
([slow] ~starting_items)=> is bigger on the inside. consider using TARDIS flag.

@Maleclypse
Copy link
Member Author

([slow] ~starting_items)=> (continued from above) ERROR : src/item_factory.cpp:2759 [void Item_factory::check_definitions() const] warnings for type bag_paper_powder_50lb:
([slow] ~starting_items)=> is bigger on the inside. consider using TARDIS flag.

I see that but as I asked in the discord if that's the case why is that a warning when there are tons of already existing bags that like the bag directly above my new bag fit the same logic but don't draw the error

@github-actions github-actions bot removed the json-styled JSON lint passed, label assigned by github actions label Oct 26, 2025
@github-actions github-actions bot added the json-styled JSON lint passed, label assigned by github actions label Oct 27, 2025
@github-actions github-actions bot added the BasicBuildPassed This PR builds correctly, label assigned by github actions label Oct 27, 2025
@GuardianDll GuardianDll merged commit d16ab19 into CleverRaven:master Oct 27, 2025
28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions Items: Containers Things that hold other things Items: Food / Vitamins Comestibles and drinks [JSON] Changes (can be) made in JSON json-styled JSON lint passed, label assigned by github actions Spawn Creatures, items, vehicles, locations appearing on map

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants