review feedback

ClickHouse · Feb 12, 2025 · 750b333 · 750b333
1 parent 4547713
commit 750b333
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/src/components/Select/common/InternalSelect.tsx b/src/components/Select/common/InternalSelect.tsx
@@ -250,7 +250,7 @@ export const InternalSelect = ({
       if (e.key === "Enter") {
         e.preventDefault();
         if (highlighted) {
-          onSelect(highlighted, "default", e);
+          onSelect(highlighted, undefined, e);
         } else if (visibleList.current.length === 0 && allowCreateOption) {
           onSelect(search, "custom", e);
         }

diff --git a/src/components/Select/common/types.ts b/src/components/Select/common/types.ts
@@ -1,4 +1,4 @@
-import { HTMLAttributes, KeyboardEvent, ReactNode } from "react";
+import { HTMLAttributes, ReactNode, SyntheticEvent } from "react";
 import { HorizontalDirection, IconName } from "@/components";
 import { PopoverProps } from "@radix-ui/react-popover";
 
@@ -77,7 +77,7 @@ interface InternalSelectProps
   onSelect: (
     value: string,
     type?: SelectionType,
-    evt?: KeyboardEvent<HTMLElement>
+    evt?: SyntheticEvent<HTMLElement>
   ) => void;
   multiple?: boolean;
   checkbox?: boolean;