Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IconButton has 2 extra pixels because of the border #539

Open
rndD opened this issue Feb 11, 2025 · 4 comments
Open

IconButton has 2 extra pixels because of the border #539

rndD opened this issue Feb 11, 2025 · 4 comments
Labels
bug Something isn't working good first issue Good for newcomers

Comments

@rndD
Copy link
Contributor

rndD commented Feb 11, 2025

Image

<IconButton> size xs should be 16x16 by design.

We can:

  • make border optional
  • remove border (why do we have it in the first place??
  • make icon smaller accordingly
@rndD rndD added bug Something isn't working good first issue Good for newcomers labels Feb 11, 2025
@rndD
Copy link
Contributor Author

rndD commented Feb 11, 2025

cc @crisalbu @ariser

@rndD
Copy link
Contributor Author

rndD commented Feb 11, 2025

@ariser
Copy link
Collaborator

ariser commented Feb 11, 2025

The border is requried for e.g. danger type, it's visible in this case
if we remove it, we need to replace it with box-shadow or perhaps outline, which don't take space
probably easier to keep it

@crisalbu
Copy link

It appears that we just need to reduce the padding by 1px - that should fix it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

3 participants