Skip to content

Commit 69062c9

Browse files
authored
Minor comment
1 parent e76cb29 commit 69062c9

File tree

1 file changed

+1
-0
lines changed

1 file changed

+1
-0
lines changed

clickhouse/columns/string.cpp

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -248,6 +248,7 @@ void ColumnString::Append(ColumnRef column) {
248248
if (blocks_.size() == 0 || blocks_.back().GetAvailable() < total_size)
249249
blocks_.emplace_back(std::max(DEFAULT_BLOCK_SIZE, total_size));
250250

251+
// Intentionally not doing items_.reserve() since that cripples performance.
251252
for (size_t i = 0; i < column->Size(); ++i) {
252253
this->AppendUnsafe((*col)[i]);
253254
}

0 commit comments

Comments
 (0)