Skip to content

Commit 29f5ffd

Browse files
committed
fix InsertClientHttpCompressionTests.insertSimplePOJOs test failed
1 parent f5ecac8 commit 29f5ffd

File tree

3 files changed

+20
-4
lines changed

3 files changed

+20
-4
lines changed

client-v2/src/main/java/com/clickhouse/client/api/data_formats/RowBinaryFormatSerializer.java

+18
Original file line numberDiff line numberDiff line change
@@ -12,6 +12,8 @@
1212
import java.math.BigInteger;
1313
import java.net.Inet4Address;
1414
import java.net.Inet6Address;
15+
import java.time.Instant;
16+
import java.time.OffsetDateTime;
1517
import java.time.ZoneId;
1618
import java.time.ZonedDateTime;
1719

@@ -145,6 +147,22 @@ public void writeDateTime64(ZonedDateTime value, int scale, ZoneId targetTz) thr
145147
SerializerUtils.writeDateTime64(out, value, scale, targetTz);
146148
}
147149

150+
public void writeDateTime32(OffsetDateTime value) throws IOException {
151+
SerializerUtils.writeDateTime32(out, value, null);
152+
}
153+
154+
public void writeDateTime64(OffsetDateTime value, int scale) throws IOException {
155+
SerializerUtils.writeDateTime64(out, value, scale, null);
156+
}
157+
158+
public void writeDateTime32(Instant value) throws IOException {
159+
SerializerUtils.writeDateTime32(out, value, null);
160+
}
161+
162+
public void writeDateTime64(Instant value, int scale) throws IOException {
163+
SerializerUtils.writeDateTime64(out, value, scale, null);
164+
}
165+
148166
public void writeEnum8(byte value) throws IOException {
149167
BinaryStreamUtils.writeEnum8(out, value);
150168
}

client-v2/src/test/java/com/clickhouse/client/insert/InsertTests.java

+2-3
Original file line numberDiff line numberDiff line change
@@ -135,7 +135,6 @@ public void insertSimplePOJOs() throws Exception {
135135
assertEquals(response.getQueryId(), uuid);
136136
}
137137

138-
139138
@Test(groups = { "integration" }, enabled = true)
140139
public void insertPOJOWithJSON() throws Exception {
141140
if (isCloud()) {
@@ -458,12 +457,12 @@ public void testWriter() throws Exception {
458457
if (row[4] == null) {
459458
formatWriter.writeDefault();
460459
} else {
461-
formatWriter.writeString((String) row[4]);
460+
formatWriter.writeDateTime((ZonedDateTime) row[4], null);
462461
}
463462
if (row[5] == null) {
464463
formatWriter.writeDefault();
465464
} else {
466-
formatWriter.writeInt8((byte) row[5]);
465+
formatWriter.writeInt8(((Integer) row[5]).byteValue());
467466
}
468467
}
469468
}, ClickHouseFormat.RowBinaryWithDefaults, new InsertSettings()).get()) {

client-v2/src/test/java/com/clickhouse/client/insert/SamplePOJO.java

-1
Original file line numberDiff line numberDiff line change
@@ -123,7 +123,6 @@ public SamplePOJO() {
123123
uint32 = (long) (random.nextDouble() * 4294967295L);
124124
uint64 = (long) (random.nextDouble() * 18446744073709615L);
125125

126-
127126
uint128 = upper.or(lower).abs();
128127
uint256 = upper1.or(upper2).or(lower1).or(lower2).abs();
129128

0 commit comments

Comments
 (0)