Merge pull request #2115 from MaheshMadushan/Windows_failing_test_fix

PR Fixes failing Test in Windows when attempting to locate files with reserved characters in the file path

Author: chernser

clickhouse-data/src/main/java/com/clickhouse/data/ClickHouseUtils.java

@@ -357,6 +357,17 @@ public static List<Path> findFiles(String pattern, String... paths) throws IOExc
         }
 
         if (!pattern.startsWith("glob:") && !pattern.startsWith("regex:")) {
+            if (IS_WINDOWS) {
+                final String reservedCharsWindows = "<>:\"|?*";
+                pattern.chars().anyMatch(
+                        value -> {
+                            if (value < ' ' || reservedCharsWindows.indexOf(value) != -1) {
+                                throw new IllegalArgumentException("File path contains reserved character <%s>".formatted((char) value));
+                            }
+                            return false;
+                        }
+                );
+            }
             Path path = Paths.get(pattern);
             if (path.isAbsolute()) {
                 return Collections.singletonList(path);

clickhouse-data/src/test/java/com/clickhouse/data/ClickHouseUtilsTest.java

@@ -7,6 +7,7 @@
 import java.util.ArrayList;
 import java.util.Arrays;
 import java.util.Collections;
+import java.util.Locale;
 import java.util.HashMap;
 import java.util.LinkedList;
 import java.util.List;
@@ -96,8 +97,20 @@ public void testFindFiles() throws IOException {
         Assert.assertThrows(IllegalArgumentException.class, () -> ClickHouseUtils.findFiles(null));
         Assert.assertThrows(IllegalArgumentException.class, () -> ClickHouseUtils.findFiles(""));
 
+        if (System.getProperty("os.name").toLowerCase(Locale.ROOT).contains("windows")) {
+            Assert.assertThrows(IllegalArgumentException.class, () -> ClickHouseUtils.findFiles("READM?.md"));
+            Assert.assertThrows(IllegalArgumentException.class, () -> ClickHouseUtils.findFiles("READM<?.md"));
+            Assert.assertThrows(IllegalArgumentException.class, () -> ClickHouseUtils.findFiles("READM>.md"));
+            Assert.assertThrows(IllegalArgumentException.class, () -> ClickHouseUtils.findFiles("READM|.md"));
+            Assert.assertThrows(IllegalArgumentException.class, () -> ClickHouseUtils.findFiles("READM*.md"));
+            Assert.assertThrows(IllegalArgumentException.class, () -> ClickHouseUtils.findFiles("READM<>:\\\"|?*.md"));
+            Assert.assertThrows(IllegalArgumentException.class, () -> ClickHouseUtils.findFiles(" "));
+        }
+        else {
+            Assert.assertEquals(ClickHouseUtils.findFiles("READM?.md").size(), 1);
+        }
+
         Assert.assertEquals(ClickHouseUtils.findFiles("README.md").size(), 1);
-        Assert.assertEquals(ClickHouseUtils.findFiles("READM?.md").size(), 1);
         Assert.assertEquals(ClickHouseUtils.findFiles("glob:*.md").size(), 1);
         Assert.assertTrue(ClickHouseUtils.findFiles("glob:**.java", "src", "..").size() >= 1);
         Assert.assertTrue(ClickHouseUtils.findFiles("glob:**.java", "src/test").size() >= 1);