Skip to content

Commit 5e8b281

Browse files
authored
chore: apply rc12 injection related changes (#80)
1 parent 3659ce1 commit 5e8b281

File tree

2 files changed

+12
-14
lines changed

2 files changed

+12
-14
lines changed

cloudnet-rest-module/src/main/java/eu/cloudnetservice/ext/modules/rest/CloudNetRestModule.java

+10-12
Original file line numberDiff line numberDiff line change
@@ -16,8 +16,7 @@
1616

1717
package eu.cloudnetservice.ext.modules.rest;
1818

19-
import dev.derklaro.aerogel.SpecifiedInjector;
20-
import dev.derklaro.aerogel.binding.BindingBuilder;
19+
import dev.derklaro.aerogel.Injector;
2120
import eu.cloudnetservice.driver.document.DocumentFactory;
2221
import eu.cloudnetservice.driver.event.EventManager;
2322
import eu.cloudnetservice.driver.inject.InjectionLayer;
@@ -108,17 +107,16 @@ public void initHttpServer(@Named("module") @NonNull InjectionLayer<?> injection
108107
// registers the validation-enabling context decorator
109108
var validationDecorator = ValidationHandlerMethodContextDecorator.withDefaultValidator();
110109
server.annotationParser().registerHandlerContextDecorator(validationDecorator);
110+
server.annotationParser().registerAnnotationProcessor(new CloudNetLoggerInterceptor());
111111

112-
// bind the server and register it for injection
112+
// bind the server listeners
113113
restConfig.httpListeners().forEach(listener -> server.addListener(listener).join());
114-
injectionLayer.install(BindingBuilder.create().bind(HttpServer.class).toInstance(server));
115-
116-
// add the cloudnet logger interceptor
117-
server.annotationParser().registerAnnotationProcessor(new CloudNetLoggerInterceptor());
118114

119-
// bind the rest user management for injection
115+
// register required instances for injection
120116
var restUserManagement = RestUserManagementLoader.load();
121-
injectionLayer.install(BindingBuilder.create().bind(RestUserManagement.class).toInstance(restUserManagement));
117+
var bindingBuilder = injectionLayer.injector().createBindingBuilder();
118+
injectionLayer.install(bindingBuilder.bind(HttpServer.class).toInstance(server));
119+
injectionLayer.install(bindingBuilder.bind(RestUserManagement.class).toInstance(restUserManagement));
122120
}
123121

124122
@ModuleTask(order = 107, lifecycle = ModuleLifeCycle.STARTED)
@@ -164,7 +162,7 @@ public void scheduleBridgeInitialization(
164162
@NonNull Scheduler scheduler,
165163
@NonNull ModuleProvider moduleProvider,
166164
@NonNull HttpServer server,
167-
@NonNull @Named("module") InjectionLayer<SpecifiedInjector> moduleLayer
165+
@NonNull @Named("module") InjectionLayer<Injector> moduleLayer
168166
) {
169167
// we want to register the bridge handlers after all modules are started
170168
scheduler.runTask(() -> CloudNetBridgeInitializer.installBridgeHandler(moduleProvider, server, moduleLayer));
@@ -178,11 +176,11 @@ public void registerListener(@NonNull EventManager eventManager) {
178176
@ModuleTask(lifecycle = ModuleLifeCycle.STOPPED)
179177
public void unregisterModule(
180178
@NonNull HttpServer httpServer,
181-
@Named("module") InjectionLayer<SpecifiedInjector> layer
179+
@Named("module") InjectionLayer<Injector> layer
182180
) {
183181
try {
184182
httpServer.close();
185-
layer.injector().removeConstructedBindings();
183+
layer.injector().close();
186184
} catch (Exception exception) {
187185
LOGGER.error("Unable to close http server while disabling cloudnet rest module.", exception);
188186
}

cloudnet-rest-module/src/main/java/eu/cloudnetservice/ext/modules/rest/listener/CloudNetBridgeInitializer.java

+2-2
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@
1616

1717
package eu.cloudnetservice.ext.modules.rest.listener;
1818

19-
import dev.derklaro.aerogel.SpecifiedInjector;
19+
import dev.derklaro.aerogel.Injector;
2020
import eu.cloudnetservice.driver.inject.InjectionLayer;
2121
import eu.cloudnetservice.driver.module.ModuleLifeCycle;
2222
import eu.cloudnetservice.driver.module.ModuleProvider;
@@ -35,7 +35,7 @@ public class CloudNetBridgeInitializer {
3535
public static void installBridgeHandler(
3636
@NonNull ModuleProvider moduleProvider,
3737
@NonNull HttpServer server,
38-
@NonNull InjectionLayer<SpecifiedInjector> moduleLayer
38+
@NonNull InjectionLayer<Injector> moduleLayer
3939
) {
4040
var bridgeModule = moduleProvider.module(BRIDGE_MODULE_NAME);
4141
if (bridgeModule == null || bridgeModule.moduleLifeCycle() != ModuleLifeCycle.STARTED) {

0 commit comments

Comments
 (0)