Bug CS-15372: IdentityProxy info should be copied over during exception handling in API layer for create(), like it is done in execute().

Description:

	1. Added exception processing for uuid lists in exceptions,
	   for commands of type BaseAsyncCreateCmd.
	2. Added nullpointer check in addProxyObject().
	3. Miscellaneous whitespace reformatting for git patching.

Conflicts:

	api/src/com/cloud/exception/CloudException.java
	utils/src/com/cloud/utils/exception/RuntimeCloudException.java

Author: Vijayendra Bhamidipati

api/src/com/cloud/exception/CloudException.java

@@ -1,73 +1,88 @@
-// Copyright 2012 Citrix Systems, Inc. Licensed under the
-// Apache License, Version 2.0 (the "License"); you may not use this
-// file except in compliance with the License.  Citrix Systems, Inc.
-// reserves all rights not expressly granted by the License.
-// You may obtain a copy of the License at http://www.apache.org/licenses/LICENSE-2.0
-// Unless required by applicable law or agreed to in writing, software
-// distributed under the License is distributed on an "AS IS" BASIS,
-// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
-// See the License for the specific language governing permissions and
-// limitations under the License.
-// 
-// Automatically generated by addcopyright.py at 04/03/2012
+/**
+ * Copyright (C) 2011 Citrix Systems, Inc.  All rights reserved
+ *
+ * This software is licensed under the GNU General Public License v3 or later.
+ *
+ * It is free software: you can redistribute it and/or modify
+ * it under the terms of the GNU General Public License as published by
+ * the Free Software Foundation, either version 3 of the License, or any later version.
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+ * GNU General Public License for more details.
+ *
+ * You should have received a copy of the GNU General Public License
+ * along with this program.  If not, see <http://www.gnu.org/licenses/>.
+ *
+ */
 package com.cloud.exception;
 
-import com.cloud.utils.IdentityProxy;
 import java.util.ArrayList;
-import com.cloud.utils.exception.CSExceptionErrorCode;
+
 import com.cloud.utils.AnnotationHelper;
+import com.cloud.utils.IdentityProxy;
+import com.cloud.utils.exception.CSExceptionErrorCode;
 
 /**
+ * CloudException is a generic exception class that has an IdentityProxy
+ * object in it to enable on the fly conversion of database ids to uuids
  * by the API response serializer. Any exceptions that are thrown by
+ * command invocations must extend this class, or the RuntimeCloudException
  * class, which extends RuntimeException instead of Exception like this
- * class does. 
+ * class does.
  */
 
 public class CloudException extends Exception {
-    
-	// This holds a list of uuids and their names. Add uuid:fieldname pairs
-	protected ArrayList<IdentityProxy> idList = new ArrayList<IdentityProxy>();
-	
-	protected Integer csErrorCode;	
-		
-	public CloudException(String message) {
-		super(message);
-		setCSErrorCode(CSExceptionErrorCode.getCSErrCode(this.getClass().getName()));
-	}
+
+    // This holds a list of uuids and their names. Add uuid:fieldname pairs
+    // if required, to this list before throwing an exception, using addProxyObject().
+    protected ArrayList<IdentityProxy> idList = new ArrayList<IdentityProxy>();
+
+    // This holds an error code. Set this before throwing an exception, if applicable.
+    protected Integer csErrorCode;
+
+    public CloudException(String message) {
+        super(message);
+        setCSErrorCode(CSExceptionErrorCode.getCSErrCode(this.getClass().getName()));
+    }
 
     public CloudException(String message, Throwable cause) {
         super(message, cause);
         setCSErrorCode(CSExceptionErrorCode.getCSErrCode(this.getClass().getName()));
     }
-    
+
     public void addProxyObject(Object voObj, Long id, String idFieldName) {
-    	// Get the VO object's table name.
-    	String tablename = AnnotationHelper.getTableName(voObj);
-    	if (tablename != null) {
-    		addProxyObject(tablename, id, idFieldName);    		
-    	}
-    	return;
+        // Get the VO object's table name.
+        if (voObj != null) {
+            String tablename = AnnotationHelper.getTableName(voObj);
+            if (tablename != null) {
+                addProxyObject(tablename, id, idFieldName);
+            }
+        }
+        return;
+    }
+
+    public CloudException() {
+        super();
+        setCSErrorCode(CSExceptionErrorCode.getCSErrCode(this.getClass().getName()));
+    }
+
+    public void addProxyObject(String tableName, Long id, String idFieldName) {
+        if (tableName != null) {
+            idList.add(new IdentityProxy(tableName, id, idFieldName));
+        }
+        return;
+    }
+
+    public ArrayList<IdentityProxy> getIdProxyList() {
+        return idList;
+    }
+
+    public void setCSErrorCode(int cserrcode) {
+        this.csErrorCode = cserrcode;
+    }
+
+    public int getCSErrorCode() {
+        return this.csErrorCode;
     }
-    
-	public CloudException() {
-		super();
-		setCSErrorCode(CSExceptionErrorCode.getCSErrCode(this.getClass().getName()));
-	}
-	
-	public void addProxyObject(String tableName, Long id, String idFieldName) {
-		idList.add(new IdentityProxy(tableName, id, idFieldName));
-		return;
-	}
-	
-	public ArrayList<IdentityProxy> getIdProxyList() {
-		return idList;
-	}
-	
-	public void setCSErrorCode(int cserrcode) {
-		this.csErrorCode = cserrcode;
-	}
-	
-	public int getCSErrorCode() {
-		return this.csErrorCode;
-	}
 }