Skip to content

Commit 85abdbc

Browse files
committed
Merge remote-tracking branch 'origin/master' into SAN-2725-new-container
2 parents 25e0413 + 2030b68 commit 85abdbc

File tree

84 files changed

+2662
-1269
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

84 files changed

+2662
-1269
lines changed

.jshintrc

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,7 @@
44
"browser": true,
55
"undef": true,
66
"nonbsp": true,
7+
"latedef": false,
78
"quotmark": "single",
89
"curly": true,
910
"globalstrict": true,

CODE-STYLE.md

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -179,3 +179,9 @@ div(
179179
baz = "baz"
180180
)
181181
```
182+
183+
## Naming
184+
PSA - new naming standards for views and directives… instead of `viewFancySelect` it’s `fancySelectView` we are trying to slowly migrate all our views to have view at the end rather than the beginning.
185+
186+
And for modals its `newContainerModalView` instead of `viewNewContainerModal`
187+

Gruntfile.js

Lines changed: 14 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -506,6 +506,19 @@ module.exports = function(grunt) {
506506
'compress:build',
507507
'concurrent'
508508
]);
509+
grunt.registerTask('server', [
510+
'copy',
511+
'sass:dev',
512+
'autoprefixer',
513+
'jade2js',
514+
'jshint:dev',
515+
'autoBundleDependencies',
516+
'generateConfigs',
517+
'browserify:watch',
518+
'jade:compile',
519+
'compress:build',
520+
'concurrent'
521+
]);
509522
grunt.registerTask('deploy', [
510523
'copy',
511524
'sass:dev',
@@ -530,4 +543,4 @@ module.exports = function(grunt) {
530543
'jade:compile',
531544
'compress:build'
532545
]);
533-
};
546+
};
Lines changed: 6 additions & 0 deletions
Loading
Lines changed: 7 additions & 0 deletions
Loading
Lines changed: 6 additions & 0 deletions
Loading
Lines changed: 6 additions & 0 deletions
Loading

client/assets/styles/scss/components/badges.scss

Lines changed: 14 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -19,8 +19,20 @@
1919
width: $input-xxs;
2020
}
2121

22-
// blue
23-
&.blue::after {
22+
// colors
23+
&.badge-blue::after {
2424
background: $blue;
2525
}
26+
27+
&.badge-green::after {
28+
background: $green;
29+
}
30+
31+
&.badge-orange::after {
32+
background: $orange;
33+
}
34+
35+
&.badge-red::after {
36+
background: $red;
37+
}
2638
}

client/assets/styles/scss/components/buttons/buttons.scss

Lines changed: 14 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -263,12 +263,12 @@
263263

264264
&.btn {
265265

266-
&:hover:not([disabled]),
266+
&:hover:not([disabled]):not(.disabled),
267267
&.hover {
268268
color: $blue;
269269
}
270270

271-
&:active:not([disabled]),
271+
&:active:not([disabled]):not(.disabled),
272272
&.active,
273273
&.active:hover {
274274
color: $blue;
@@ -284,13 +284,13 @@
284284

285285
&.btn {
286286

287-
&:hover:not([disabled]),
287+
&:hover:not([disabled]):not(.disabled),
288288
&.hover {
289289
background: $white;
290290
border-color: $gray-light;
291291
}
292292

293-
&:active:not([disabled]),
293+
&:active:not([disabled]):not(.disabled),
294294
&.active,
295295
&.active:hover {
296296
background: $white;
@@ -325,12 +325,12 @@
325325
&.btn {
326326

327327
// states
328-
&:hover:not([disabled]),
328+
&:hover:not([disabled]):not(.disabled),
329329
&.hover {
330330
background: #8ae09c; // rgba($green,.6);
331331
}
332332

333-
&:active:not([disabled]),
333+
&:active:not([disabled]):not(.disabled),
334334
&.active,
335335
&.active:hover {
336336
background: $green;
@@ -353,12 +353,12 @@
353353

354354
&.btn {
355355

356-
&:hover:not([disabled]),
356+
&:hover:not([disabled]):not(.disabled),
357357
&.hover {
358358
background: $orange-lighter;
359359
}
360360

361-
&:active:not([disabled]),
361+
&:active:not([disabled]):not(.disabled),
362362
&.active,
363363
&.active:hover {
364364
background: $orange;
@@ -376,12 +376,12 @@
376376
border-color: $white;
377377
color: $white;
378378

379-
&:hover:not([disabled]),
379+
&:hover:not([disabled]):not(.disabled),
380380
&.hover {
381381
background: rgba($white,.1);
382382
}
383383

384-
&:active:not([disabled]),
384+
&:active:not([disabled]):not(.disabled),
385385
&.active,
386386
&.active:hover {
387387
background: $white;
@@ -411,12 +411,12 @@
411411
border-color: $red-dark;
412412
color: $white;
413413

414-
&:hover:not([disabled]),
414+
&:hover:not([disabled]):not(.disabled),
415415
&.hover {
416416
background: $red-light;
417417
}
418418

419-
&:active:not([disabled]),
419+
&:active:not([disabled]):not(.disabled),
420420
&.active,
421421
&.active:hover {
422422
background: $red-dark;
@@ -432,12 +432,12 @@
432432
&.btn {
433433
background: $white;
434434

435-
&:hover:not([disabled]),
435+
&:hover:not([disabled]):not(.disabled),
436436
&.hover {
437437
border-color: $gray-light;
438438
}
439439

440-
&:active:not([disabled]),
440+
&:active:not([disabled]):not(.disabled),
441441
&.active,
442442
&.active:hover {
443443
border-color: $purple-light;

client/assets/styles/scss/layout/instance-header.scss

Lines changed: 16 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -140,6 +140,7 @@
140140
background: transparent;
141141
flex: 1 1 auto;
142142
height: $input-sm;
143+
min-width: 0;
143144
width: 100%;
144145
}
145146
}
@@ -167,8 +168,8 @@
167168
}
168169

169170
.icons-notification {
170-
border-color: $white;
171-
color: $white;
171+
background: $white;
172+
color: $red;
172173
}
173174
}
174175

@@ -180,10 +181,20 @@
180181
.icons-arrow-down {
181182
width: 21px;
182183
}
184+
185+
.icons-notification {
186+
background: $orange;
187+
border-radius: 50%;
188+
color: $white;
189+
height: 15px;
190+
margin: 0 0 0 8px;
191+
top: 9px;
192+
width: 15px;
193+
}
183194
}
184195

185196
// dns button
186-
.btn-dns {
197+
.btn.btn-dns {
187198
color: $gray-light;
188199
font-size: 14px;
189200
font-weight: $weight-bold;
@@ -196,11 +207,11 @@
196207
background: transparent;
197208
border: 0;
198209

199-
&:hover {
210+
&:hover:not([disabled]):not(.disabled) {
200211
background: transparent;
201212
}
202213

203-
&:active {
214+
&:active:not([disabled]):not(.disabled) {
204215
background: transparent;
205216
}
206217

0 commit comments

Comments
 (0)