fixes

Author: imjaspreet

ecs-fargate-wordpress-rds-terraform/ecs.tf

@@ -1,9 +1,9 @@
 resource "aws_ecs_cluster" "default" {
-    name = "${var.ecs_cluster_name}"
+  name = var.ecs_cluster_name
 }
 
 resource "aws_cloudwatch_log_group" "ecs_log_group" {
-  name = "/ecs/wp-ecs-tf"
+  name              = "/ecs/wp-ecs-tf"
   retention_in_days = 7
 
   tags = {
@@ -12,14 +12,8 @@ resource "aws_cloudwatch_log_group" "ecs_log_group" {
   }
 }
 
-data "aws_iam_role" "existing_ecs_task_execution_role" {
-  name = "ecsTaskExecutionRole"
-}
-
 resource "aws_iam_role" "ecs_task_execution_role" {
-  count = length(data.aws_iam_role.existing_ecs_task_execution_role.arn) == 0 ? 1 : 0
-
-  name = "ecsTaskExecutionRole"
+  name = "ecsTaskExecutionRole-tf"
 
   assume_role_policy = jsonencode({
     Version = "2012-10-17"
@@ -36,21 +30,19 @@ resource "aws_iam_role" "ecs_task_execution_role" {
 }
 
 resource "aws_iam_role_policy_attachment" "ecs_task_execution_role_policy" {
-  count = length(data.aws_iam_role.existing_ecs_task_execution_role.arn) == 0 ? 1 : 0
-
-  role       = aws_iam_role.ecs_task_execution_role[count.index].name
+  role       = aws_iam_role.ecs_task_execution_role.name
   policy_arn = "arn:aws:iam::aws:policy/service-role/AmazonECSTaskExecutionRolePolicy"
 }
 
 resource "aws_ecs_task_definition" "wordpress" {
-  family                = "wp-ecs-task-tf"
-  container_definitions = data.template_file.wp-container.rendered
+  family                   = "wp-ecs-task-tf"
+  container_definitions    = data.template_file.wp-container.rendered
   requires_compatibilities = ["FARGATE"]
-  network_mode          = "awsvpc"
-  cpu                   = 512
-  memory                = 1024
+  network_mode             = "awsvpc"
+  cpu                      = 512
+  memory                   = 1024
 
-  execution_role_arn = length(data.aws_iam_role.existing_ecs_task_execution_role.arn) == 0 ? aws_iam_role.ecs_task_execution_role[0].arn : data.aws_iam_role.existing_ecs_task_execution_role.arn
+  execution_role_arn = aws_iam_role.ecs_task_execution_role.arn
 
   runtime_platform {
     operating_system_family = "LINUX"
@@ -59,21 +51,21 @@ resource "aws_ecs_task_definition" "wordpress" {
 }
 
 resource "aws_ecs_service" "wp-ecs-svc" {
-    name = "wp-ecs-svc-tf"
-    cluster = "${aws_ecs_cluster.default.id}"
-    task_definition = "${aws_ecs_task_definition.wordpress.arn}"
-    desired_count = 1
-    launch_type = "FARGATE"
-    
-    load_balancer {
-        target_group_arn = "${aws_lb_target_group.default.arn}"
-        container_name = "wordpress"
-        container_port = 80
-    }
+  name            = "wp-ecs-svc-tf"
+  cluster         = aws_ecs_cluster.default.id
+  task_definition = aws_ecs_task_definition.wordpress.arn
+  desired_count   = 1
+  launch_type     = "FARGATE"
 
-    network_configuration {
-        subnets             = ["${aws_subnet.wp-public-a-tf.id}", "${aws_subnet.wp-public-b-tf.id}", "${aws_subnet.wp-public-c-tf.id}"]
-        security_groups     = ["${aws_security_group.wp-alb-tf.id}"]
-        assign_public_ip    = true
-    }
+  load_balancer {
+    target_group_arn = aws_lb_target_group.default.arn
+    container_name   = "wordpress"
+    container_port   = 80
+  }
+
+  network_configuration {
+    subnets          = [aws_subnet.wp-public-a-tf.id, aws_subnet.wp-public-b-tf.id, aws_subnet.wp-public-c-tf.id]
+    security_groups  = [aws_security_group.wp-alb-tf.id]
+    assign_public_ip = true
+  }
 }