WebDriverNotConstraint can receive non-string selecters on 2.5

Naktibalda · Naktibalda · commit 9f4b7c3f904b · 2019-02-26T22:46:10.000+02:00
diff --git a/src/Constraint/WebDriverNot.php b/src/Constraint/WebDriverNot.php
@@ -13,6 +13,9 @@ protected function matches($nodes) : bool
 
     protected function fail($nodes, $selector, ComparisonFailure $comparisonFailure = null) : void
     {
+        if (!is_string($selector) || strpos($selector, "'") === false) {
+            $selector = Locator::humanReadableString($selector);
+        }
         if (!$this->string) {
             throw new \PHPUnit\Framework\ExpectationFailedException(
                 "Element $selector was found",

Original file line number	Diff line number	Diff line change
`@@ -13,6 +13,9 @@ protected function matches($nodes) : bool`
`13`	`13`
`14`	`14`	`protected function fail($nodes, $selector, ComparisonFailure $comparisonFailure = null) : void`
`15`	`15`	`{`
	`16`	`+ if (!is_string($selector) \|\| strpos($selector, "'") === false) {`
	`17`	`+ $selector = Locator::humanReadableString($selector);`
	`18`	`+ }`
`16`	`19`	`if (!$this->string) {`
`17`	`20`	`throw new \PHPUnit\Framework\ExpectationFailedException(`
`18`	`21`	`"Element $selector was found",`