test: fix development.php to also return if we run a test as a separate process

Author: carlalexander

development.php

@@ -4,7 +4,15 @@
  *
  * @package ThemeIsle
  */
-if ( defined( 'PHPUNIT_COMPOSER_INSTALL' ) ) {
+
+// This condition tries to detect if we're running PHPUnit. This is complex because the file is loaded via the
+// composer autoloader. You can detect that 99% of the time because PHPUnit uses the constant
+// PHPUNIT_COMPOSER_INSTALL to load the autoloader. That said, if you run a test in a separate process, it won't
+// run that code again and the constant doesn't exist. As a fallback, we use the PHPUNIT_RUNNING environment variable
+// defined in the phpunit.xml to detect if we're in a PHPUnit process. We can't always use the environment variable
+// because by default PHPUnit loads the composer autoloader before it assigns those environment variables. That's
+// why both conditions are needed.
+if ( defined( 'PHPUNIT_COMPOSER_INSTALL' ) || getenv( 'PHPUNIT_RUNNING' ) ) {
 	return;
 }
 

phpunit.xml

@@ -6,6 +6,10 @@
         convertNoticesToExceptions="true"
         convertWarningsToExceptions="true"
 >
+    <php>
+        <env name="PHPUNIT_RUNNING" value="1"/>
+    </php>
+
     <testsuites>
         <testsuite name="General Unit tests ( Requires PHP 5.4) " >
             <directory phpVersion="5.4.0" phpVersionOperator=">=" prefix="test-"  suffix=".php">./tests/</directory>