Warn when star is in LHS of the declaration

Also update tests to include star_in_LHS.f test which checks the
behavior of this code.

Signed-off-by: Ben Brewer <[email protected]>

Author: Francisco Redondo Marchena

include/ofc/cliarg.h

@@ -37,6 +37,7 @@ typedef enum
 	OFC_CLIARG_NO_WARN_NAMESPACE_COL,
 	OFC_CLIARG_NO_WARN_TYPE_IO,
 	OFC_CLIARG_NO_WARN_NO_LOGICAL_IF,
+	OFC_CLIARG_NO_WARN_STAR_IN_LHS,
 	OFC_CLIARG_NO_WARN_PEDANTIC,
 	OFC_CLIARG_WARN_UNUSED_PROCEDURE,
 	OFC_CLIARG_PARSE_ONLY,

include/ofc/global_opts.h

@@ -29,6 +29,7 @@ typedef struct
 	bool no_warn_namespace_col;
 	bool no_warn_type_io;
 	bool no_warn_no_logical_if;
+	bool no_warn_star_in_lhs;
 	bool warn_unused_procedure;
 	bool parse_only;
 	bool parse_print;
@@ -49,6 +50,7 @@ static const ofc_global_opts_t
 	.no_warn_namespace_col = false,
 	.no_warn_type_io       = false,
 	.no_warn_no_logical_if = false,
+	.no_warn_star_in_lhs   = false,
 	.warn_unused_procedure = false,
 	.parse_only            = false,
 	.parse_print           = false,

src/cliarg.c

@@ -49,6 +49,9 @@ static bool ofc_cliarg_global_opts__set_flag(
 		case OFC_CLIARG_NO_WARN_NO_LOGICAL_IF:
 			global->no_warn_no_logical_if = true;
 			break;
+		case OFC_CLIARG_NO_WARN_STAR_IN_LHS:
+			global->no_warn_star_in_lhs = true;
+			break;
 		case OFC_CLIARG_NO_WARN_PEDANTIC:
 			global->no_warn_equiv_type    = true;
 			global->no_warn_name_keyword  = true;
@@ -253,6 +256,7 @@ static const ofc_cliarg_body_t cliargs[] =
 	{ OFC_CLIARG_NO_WARN_NAMESPACE_COL, "no-warn-namespace-col", '\0', "Suppress namespace collision warning",       OFC_CLIARG_PARAM_GLOB_NONE, 0, true  },
 	{ OFC_CLIARG_NO_WARN_TYPE_IO,       "no-warn-type-io",       '\0', "Suppress TYPE as IO statement warning",      OFC_CLIARG_PARAM_GLOB_NONE, 0, true  },
 	{ OFC_CLIARG_NO_WARN_NO_LOGICAL_IF, "no_warn_no_logical_if", '\0', "Suppress No logical if condition warning",   OFC_CLIARG_PARAM_GLOB_NONE, 0, true  },
+	{ OFC_CLIARG_NO_WARN_STAR_IN_LHS,   "no-warn-star-in-lhs",   '\0', "Suppress star in lhs warning",               OFC_CLIARG_PARAM_GLOB_NONE, 0, true  },
 	{ OFC_CLIARG_NO_WARN_PEDANTIC,      "no-warn-pedantic",      'p',  "Suppress all pedantic warnings",             OFC_CLIARG_PARAM_GLOB_NONE, 0, true  },
 	{ OFC_CLIARG_WARN_UNUSED_PROCEDURE, "warn-unused-procedure", '\0', "Enable unused procedure warnings",           OFC_CLIARG_PARAM_GLOB_NONE, 0, true  },
 	{ OFC_CLIARG_PARSE_ONLY,            "parse-only",            '\0', "Runs the parser only",                       OFC_CLIARG_PARAM_GLOB_NONE, 0, true  },

src/sema/decl.c

@@ -14,6 +14,7 @@
  */
 
 #include "ofc/sema.h"
+#include "ofc/global.h"
 
 
 static void ofc_sema_decl_init__delete(
@@ -533,6 +534,13 @@ static bool ofc_sema_decl__elem(
 			ofc_sema_array_delete(array);
 			return false;
 		}
+
+		if (!global_opts.no_warn_star_in_lhs)
+		{
+			ofc_sparse_ref_warning(lhs->src,
+				"Star %s should only be used on decl type",
+				(ofc_sema_type_is_character(type) ? "LEN" : "KIND"));
+		}
 	}
 
 	if (!ofc_sparse_ref_empty(pdecl->record))