Mark all subroutine call arguments as used

We can't know if the arguments of a subroutine call have been
written to in the call, so we assume they are

Author: violetamenendez

include/ofc/sema/dummy_arg.h

@@ -77,6 +77,9 @@ ofc_sema_dummy_arg_t* ofc_sema_dummy_arg_wrap_expr(
 const ofc_sema_type_t* ofc_sema_dummy_arg_type(
 	const ofc_sema_dummy_arg_t* dummy_arg);
 
+bool ofc_sema_dummy_arg_mark_used(
+	ofc_sema_dummy_arg_t* dummy_arg);
+
 ofc_sema_dummy_arg_t* ofc_sema_dummy_arg_copy_replace(
 	const ofc_sema_dummy_arg_t* dummy_arg,
 	const ofc_sema_decl_t* replace,

src/sema/dummy_arg.c

@@ -365,6 +365,37 @@ bool ofc_sema_dummy_arg_compare(
 	return false;
 }
 
+bool ofc_sema_dummy_arg_mark_used(
+	ofc_sema_dummy_arg_t* dummy_arg)
+{
+	if (!dummy_arg)
+		return false;
+
+	switch (dummy_arg->type)
+	{
+		case OFC_SEMA_DUMMY_ARG_EXPR:
+			if (dummy_arg->expr->type == OFC_SEMA_EXPR_LHS)
+			{
+				if (!ofc_sema_lhs_mark_used(
+					dummy_arg->expr->lhs, true, true))
+					return false;
+			}
+			break;
+		case OFC_SEMA_DUMMY_ARG_EXTERNAL:
+			if (dummy_arg->external->decl)
+			{
+				if (!ofc_sema_decl_mark_used(
+					dummy_arg->external->decl, true, true))
+					return false;
+			}
+			break;
+		default:
+			break;
+	}
+
+	return true;
+}
+
 ofc_sema_dummy_arg_list_t* ofc_sema_dummy_arg_list_copy_replace(
 	const ofc_sema_dummy_arg_list_t* list,
 	const ofc_sema_decl_t* replace,

src/sema/stmt/call.c

@@ -98,6 +98,14 @@ ofc_sema_stmt_t* ofc_sema_stmt_call(
 				return NULL;
 			}
 
+			/* We mark all dummy_arg as used, as we can't know if
+			   they have been read or written to in the call */
+			if (!ofc_sema_dummy_arg_mark_used(dummy_arg))
+			{
+				ofc_sema_dummy_arg_list_delete(args);
+				return NULL;
+			}
+
 			if (!ofc_sema_dummy_arg_list_add(
 				args, dummy_arg))
 			{