Skip to content

Commit 8a039f4

Browse files
ColinEberhardtColinEberhardt
committed
test: further triage
1 parent 5216524 commit 8a039f4

File tree

2 files changed

+61
-46
lines changed

2 files changed

+61
-46
lines changed

‎assembly/__spec_tests__/generated.spec.ts

+44-44
Original file line numberDiff line numberDiff line change
@@ -1003,9 +1003,9 @@ it("line: 185 - matches ^\\*\\.[a-z]([a-z\\-\\d]*[a-z\\d]+)?(\\.[a-z]([a-z\\-\\d
10031003
["*.c-a.0-c"]
10041004
);
10051005
});
1006-
xit("line: 186 - non capturing groups not supported", () => {});
1007-
xit("line: 187 - non capturing groups not supported", () => {});
1008-
xit("line: 188 - non capturing groups not supported", () => {});
1006+
xit("line: 186 - lookaheads not supported", () => {});
1007+
xit("line: 187 - lookaheads not supported", () => {});
1008+
xit("line: 188 - lookaheads not supported", () => {});
10091009
it("line: 189 - matches ^[\\da-f](\\.[\\da-f])*$ against 'a.b.c.d'", () => {
10101010
const match = exec("^[\\da-f](\\.[\\da-f])*$", "a.b.c.d", "mis");
10111011
expect(match.matches[0]).toBe("a.b.c.d".substring(0, 7));
@@ -1042,12 +1042,12 @@ it("line: 196 - matches ^$ against ''", () => {
10421042
const match = exec("^$", "", "ms");
10431043
expect(match.matches[0]).toBe("".substring(0, 0));
10441044
});
1045-
xit("line: 197 - non capturing groups not supported", () => {});
1046-
xit("line: 198 - non capturing groups not supported", () => {});
1047-
xit("line: 199 - non capturing groups not supported", () => {});
1048-
xit("line: 200 - non capturing groups not supported", () => {});
1049-
xit("line: 201 - non capturing groups not supported", () => {});
1050-
xit("line: 202 - non capturing groups not supported", () => {});
1045+
xit("line: 197 - JS regex does not support comments", () => {});
1046+
xit("line: 198 - JS regex does not support comments", () => {});
1047+
xit("line: 199 - JS regex does not support comments", () => {});
1048+
xit("line: 200 - JS regex does not support comments", () => {});
1049+
xit("line: 201 - JS regex does not support comments", () => {});
1050+
xit("line: 202 - JS regex does not support comments", () => {});
10511051
xit("line: 203 - test appears to be incorrect?", () => {});
10521052
xit("line: 204 - test appears to be incorrect?", () => {});
10531053
it("line: 205 - matches ^ a\\ b[c ]d $ against 'abcd'", () => {
@@ -1243,10 +1243,10 @@ it("line: 250 - matches ^[aeiou\\d]{4,5}? against '123456'", () => {
12431243
xit("line: 251 - back references are not supported", () => {});
12441244
xit("line: 252 - back references are not supported", () => {});
12451245
xit("line: 253 - back references are not supported", () => {});
1246-
xit("line: 254 - non capturing groups not supported", () => {});
1247-
xit("line: 255 - non capturing groups not supported", () => {});
1248-
xit("line: 256 - non capturing groups not supported", () => {});
1249-
xit("line: 257 - non capturing groups not supported", () => {});
1246+
xit("line: 254 - JS regex does not support comments", () => {});
1247+
xit("line: 255 - JS regex does not support comments", () => {});
1248+
xit("line: 256 - JS regex does not support comments", () => {});
1249+
xit("line: 257 - JS regex does not support comments", () => {});
12501250
xit("line: 258 - back references are not supported", () => {});
12511251
xit("line: 259 - back references are not supported", () => {});
12521252
xit("line: 260 - back references are not supported", () => {});
@@ -1303,23 +1303,23 @@ it("line: 266 - matches ^12.34 against '12\r34'", () => {
13031303
const match = exec("^12.34", "12\r34", "ms");
13041304
expect(match.matches[0]).toBe("12\r34".substring(0, 5));
13051305
});
1306-
xit("line: 267 - non capturing groups not supported", () => {});
1307-
xit("line: 268 - non capturing groups not supported", () => {});
1306+
xit("line: 267 - lookaheads not supported", () => {});
1307+
xit("line: 268 - lookaheads not supported", () => {});
13081308
xit("line: 269 - non capturing groups not supported", () => {});
13091309
xit("line: 270 - non capturing groups not supported", () => {});
13101310
xit("line: 271 - non capturing groups not supported", () => {});
13111311
xit("line: 272 - non capturing groups not supported", () => {});
1312-
xit("line: 273 - non capturing groups not supported", () => {});
1313-
xit("line: 274 - non capturing groups not supported", () => {});
1312+
xit("line: 273 - lookaheads not supported", () => {});
1313+
xit("line: 274 - lookaheads not supported", () => {});
13141314
xit("line: 281 - test regex contains syntax not supported in JS", () => {});
13151315
xit("line: 282 - back references are not supported", () => {});
13161316
xit("line: 283 - back references are not supported", () => {});
13171317
xit("line: 284 - back references are not supported", () => {});
13181318
xit("line: 285 - back references are not supported", () => {});
1319-
xit("line: 286 - non capturing groups not supported", () => {});
1320-
xit("line: 287 - non capturing groups not supported", () => {});
1321-
xit("line: 288 - non capturing groups not supported", () => {});
1322-
xit("line: 289 - non capturing groups not supported", () => {});
1319+
xit("line: 286 - lookaheads not supported", () => {});
1320+
xit("line: 287 - lookaheads not supported", () => {});
1321+
xit("line: 288 - lookaheads not supported", () => {});
1322+
xit("line: 289 - lookaheads not supported", () => {});
13231323
xit("line: 290 - the test behaviour differs between PCRE and JS", () => {});
13241324
it("line: 291 - matches ^[ab]{1,3}?(ab*|b) against 'aabbbbb'", () => {
13251325
const match = exec("^[ab]{1,3}?(ab*|b)", "aabbbbb", "ms");
@@ -1676,7 +1676,7 @@ xit("line: 1217 - back references are not supported", () => {});
16761676
xit("line: 1218 - back references are not supported", () => {});
16771677
xit("line: 1219 - back references are not supported", () => {});
16781678
xit("line: 1220 - back references are not supported", () => {});
1679-
xit("line: 1221 - non capturing groups not supported", () => {});
1679+
xit("line: 1221 - back references are not supported", () => {});
16801680
it("line: 1223 - matches ab\\gdef against 'abgdef'", () => {
16811681
const match = exec("ab\\gdef", "abgdef", "ms");
16821682
expect(match.matches[0]).toBe("abgdef".substring(0, 6));
@@ -1694,7 +1694,7 @@ xit("line: 1227 - back references are not supported", () => {});
16941694
xit("line: 1228 - back references are not supported", () => {});
16951695
xit("line: 1229 - back references are not supported", () => {});
16961696
xit("line: 1230 - back references are not supported", () => {});
1697-
xit("line: 1231 - non capturing groups not supported", () => {});
1697+
xit("line: 1231 - JS regex does not support mode modifiers", () => {});
16981698
xit("line: 1232 - word boundary class not supported yet!", () => {});
16991699
xit("line: 1233 - word boundary class not supported yet!", () => {});
17001700
xit("line: 1234 - word boundary class not supported yet!", () => {});
@@ -1839,12 +1839,12 @@ it("line: 1273 - matches (\\.\\d\\d[1-9]?)\\d+ against '1.235 '", () => {
18391839
expect(match.matches[0]).toBe("1.235 ".substring(1, 5));
18401840
expect(match.matches[1]).toBe("1.235 ".substring(1, 4));
18411841
});
1842-
xit("line: 1274 - non capturing groups not supported", () => {});
1843-
xit("line: 1275 - non capturing groups not supported", () => {});
1844-
xit("line: 1276 - non capturing groups not supported", () => {});
1845-
xit("line: 1277 - non capturing groups not supported", () => {});
1846-
xit("line: 1278 - non capturing groups not supported", () => {});
1847-
xit("line: 1279 - non capturing groups not supported", () => {});
1842+
xit("line: 1274 - lookaheads not supported", () => {});
1843+
xit("line: 1275 - lookaheads not supported", () => {});
1844+
xit("line: 1276 - lookaheads not supported", () => {});
1845+
xit("line: 1277 - lookaheads not supported", () => {});
1846+
xit("line: 1278 - the test behaviour differs between PCRE and JS", () => {});
1847+
xit("line: 1279 - JS regex does not support comments", () => {});
18481848
xit("line: 1280 - word boundary class not supported yet!", () => {});
18491849
it("line: 1281 - matches foo(.*)bar against 'The food is under the bar in the barn.'", () => {
18501850
const match = exec(
@@ -1910,9 +1910,9 @@ it("line: 1290 - matches (.*\\D)(\\d+)$ against 'I have 2 numbers: 53147'", () =
19101910
expect(match.matches[1]).toBe("I have 2 numbers: 53147".substring(0, 18));
19111911
expect(match.matches[2]).toBe("I have 2 numbers: 53147".substring(18, 23));
19121912
});
1913-
xit("line: 1291 - non capturing groups not supported", () => {});
1914-
xit("line: 1292 - non capturing groups not supported", () => {});
1915-
xit("line: 1293 - non capturing groups not supported", () => {});
1913+
xit("line: 1291 - lookaheads not supported", () => {});
1914+
xit("line: 1292 - lookaheads not supported", () => {});
1915+
xit("line: 1293 - lookaheads not supported", () => {});
19161916
it("line: 1294 - matches ^[W-]46] against 'W46]789 '", () => {
19171917
const match = exec("^[W-]46]", "W46]789 ", "ms");
19181918
expect(match.matches[0]).toBe("W46]789 ".substring(0, 4));
@@ -2211,12 +2211,12 @@ it("line: 1372 - matches (.*X|^B) against 'abcde\nBar '", () => {
22112211
expect(match.matches[0]).toBe("abcde\nBar ".substring(6, 7));
22122212
expect(match.matches[1]).toBe("abcde\nBar ".substring(6, 7));
22132213
});
2214-
xit("line: 1373 - non capturing groups not supported", () => {});
2215-
xit("line: 1374 - non capturing groups not supported", () => {});
2216-
xit("line: 1375 - non capturing groups not supported", () => {});
2217-
xit("line: 1376 - non capturing groups not supported", () => {});
2218-
xit("line: 1377 - non capturing groups not supported", () => {});
2219-
xit("line: 1378 - non capturing groups not supported", () => {});
2214+
xit("line: 1373 - JS regex does not support mode modifiers", () => {});
2215+
xit("line: 1374 - JS regex does not support mode modifiers", () => {});
2216+
xit("line: 1375 - JS regex does not support mode modifiers", () => {});
2217+
xit("line: 1376 - JS regex does not support mode modifiers", () => {});
2218+
xit("line: 1377 - JS regex does not support mode modifiers", () => {});
2219+
xit("line: 1378 - JS regex does not support mode modifiers", () => {});
22202220
it("line: 1379 - matches ^.*B against 'abc\nB'", () => {
22212221
const match = exec("^.*B", "abc\nB", "ms");
22222222
expect(match.matches[0]).toBe("abc\nB".substring(0, 5));
@@ -2225,12 +2225,12 @@ it("line: 1380 - matches ^.*B against 'abc\nB'", () => {
22252225
const match = exec("^.*B", "abc\nB", "m");
22262226
expect(match.matches[0]).toBe("abc\nB".substring(4, 5));
22272227
});
2228-
xit("line: 1381 - non capturing groups not supported", () => {});
2229-
xit("line: 1382 - non capturing groups not supported", () => {});
2230-
xit("line: 1383 - non capturing groups not supported", () => {});
2231-
xit("line: 1384 - non capturing groups not supported", () => {});
2232-
xit("line: 1385 - non capturing groups not supported", () => {});
2233-
xit("line: 1386 - non capturing groups not supported", () => {});
2228+
xit("line: 1381 - JS regex does not support mode modifiers", () => {});
2229+
xit("line: 1382 - JS regex does not support mode modifiers", () => {});
2230+
xit("line: 1383 - JS regex does not support mode modifiers", () => {});
2231+
xit("line: 1384 - JS regex does not support mode modifiers", () => {});
2232+
xit("line: 1385 - JS regex does not support mode modifiers", () => {});
2233+
xit("line: 1386 - JS regex does not support mode modifiers", () => {});
22342234
it("line: 1387 - matches ^[0-9][0-9][0-9][0-9][0-9][0-9][0-9][0-9][0-9][0-9][0-9][0-9] against '123456654321'", () => {
22352235
const match = exec(
22362236
"^[0-9][0-9][0-9][0-9][0-9][0-9][0-9][0-9][0-9][0-9][0-9][0-9]",

‎spec/test-generator.js

+17-2
Original file line numberDiff line numberDiff line change
@@ -47,7 +47,7 @@ const knownIssues = {
4747
1164,
4848
],
4949
"test regex contains syntax not supported in JS": [82, 1158, 281],
50-
"the test behaviour differs between PCRE and JS": [290],
50+
"the test behaviour differs between PCRE and JS": [290, 1278],
5151
};
5252

5353
const hasKnownIssue = (index) => {
@@ -108,11 +108,26 @@ lines.forEach((line, index) => {
108108
return;
109109
}
110110

111-
if (["(?"].some((f) => regex.includes(f))) {
111+
if (["(?:"].some((f) => regex.includes(f))) {
112112
testCase += `xit("line: ${index} - non capturing groups not supported", () => {});`;
113113
return;
114114
}
115115

116+
if (["(?!", "(?="].some((f) => regex.includes(f))) {
117+
testCase += `xit("line: ${index} - lookaheads not supported", () => {});`;
118+
return;
119+
}
120+
121+
if (["(?m", "(?s", "(?ms"].some((f) => regex.includes(f))) {
122+
testCase += `xit("line: ${index} - JS regex does not support mode modifiers", () => {});`;
123+
return;
124+
}
125+
126+
if (["(?#"].some((f) => regex.includes(f))) {
127+
testCase += `xit("line: ${index} - JS regex does not support comments", () => {});`;
128+
return;
129+
}
130+
116131
if (regex.match(/\\\\\d{1}/)) {
117132
testCase += `xit("line: ${index} - back references are not supported", () => {});`;
118133
return;

0 commit comments

Comments
 (0)