Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Setup phpcs and maybe run in CI #1

Open
hfiguiere opened this issue Oct 21, 2024 · 0 comments
Open

Setup phpcs and maybe run in CI #1

hfiguiere opened this issue Oct 21, 2024 · 0 comments
Milestone
1.0.0

Comments

@hfiguiere
Copy link
Collaborator

Setup phpcs and maybe run in CI to detect issue with code.
hfiguiere added a commit that referenced this issue Oct 23, 2024
@hfiguiere
composer: Added phpcs
2e1927c 
See #1

Signed-off-by: Hubert Figuière <[email protected]>
hfiguiere added a commit that referenced this issue Oct 23, 2024
@hfiguiere
rename files to follow phpcs Wordpress
16b2d5a 
See #1

Signed-off-by: Hubert Figuière <[email protected]>
hfiguiere added a commit that referenced this issue Oct 23, 2024
@hfiguiere
Run phpcbf on all files
d8ae97b 
See #1

Signed-off-by: Hubert Figuière <[email protected]>
hfiguiere added a commit that referenced this issue Oct 23, 2024
@hfiguiere
Fix many phpcs error
5bd8646 
wp_queue_script()/wp_queue_style() now get a real version
Reorder some code
Set visibility of many methods
Doc comments
Some argument typing

See #1

Signed-off-by: Hubert Figuière <[email protected]>
hfiguiere added a commit that referenced this issue Oct 28, 2024
@hfiguiere
templates/frame: suppress a warning about stylesheets
b14668e 
See #1

Signed-off-by: Hubert Figuière <[email protected]>
hfiguiere added a commit that referenced this issue Oct 28, 2024
@hfiguiere
i18n: The domain must be a string literal
44341cd 
This suppress a phpcs error

See #1

Signed-off-by: Hubert Figuière <[email protected]>
hfiguiere added a commit that referenced this issue Oct 28, 2024
@hfiguiere
coolrequest: Remove deprecated libxml_disable_entity_loader()
232f55d 
Fix a phpcs error.

See #1

Signed-off-by: Hubert Figuière <[email protected]>
hfiguiere added a commit that referenced this issue Dec 5, 2024
@hfiguiere
wopi: Disable a few PHP CS rules locally
d132042 
See issue #1

Signed-off-by: Hubert Figuière <[email protected]>
hfiguiere added a commit that referenced this issue Dec 5, 2024
@hfiguiere
php: Added composer script and some build instructions
25b13bb 
See issue #1

Signed-off-by: Hubert Figuière <[email protected]>
@hfiguiere hfiguiere added this to the 1.0.0 milestone Jan 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.0.0
Development

No branches or pull requests
1 participant
@hfiguiere