Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Proposal] Add extension to sample files and change snippets theme #28

Open
leandrocp opened this issue Sep 16, 2024 · 1 comment
Open

Comments

@leandrocp
Copy link
Contributor

leandrocp commented Sep 16, 2024

Hey that file snippets.html is super useful and now I'm wondering if we could add the actual extension to each one of the sample files. The reason is to be able to see the colors on the local editor so we can compare the generated colors.

So we could use the github_light theme here to generate the snippets

let theme = Theme::from_helix(vendored::ADWAITA_DARK)

And also rename the sample files, for eg rename Elixir to Elixir.ex

That would make it easier to validate the snippets by comparing against the preview on github.com, for eg we would be able to inspect https://github.com/Colonial-Dev/inkjet/blob/master/tests/samples/Elixir with colors or inspect the snippets.html file locally as well.

Wdyt?

Update

The sample file would look like https://github.com/leandrocp/inkjet/blob/lp-inspect-samples/tests/samples/Elixir.ex and the snippet as the screenshot below:

elixir
@leandrocp leandrocp changed the title [Proposal] Add extension to sample files [Proposal] Add extension to sample files and change snippets theme Sep 16, 2024
@Colonial-Dev
Copy link
Owner

Sure, sounds like a great idea! I'll probably generate a snippets_light and a snippets_dark, but that's neither here nor there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants