Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: CustomWindSnow does not ensure Visibility during Fade #74

Open
2 tasks done
Sarrg opened this issue Nov 27, 2024 · 1 comment
Open
2 tasks done

[Bug]: CustomWindSnow does not ensure Visibility during Fade #74

Sarrg opened this issue Nov 27, 2024 · 1 comment
Labels
bug Something isn't working

Comments

@Sarrg
Copy link

Sarrg commented Nov 27, 2024

Before You Report

  • My mods and Everest install are up to date.
  • I have recreated the bug with a minimum number of mods installed.

What platform are you playing on?

Windows 11

Bug Description

In the Update call of the Backdrop class the visibility is set instantly to IsVisible(level) unless transitioning from one room to another.
This is also used to calculate visibleFade inCustomWindSnow and since the Visible field handles if the Backdrop is rendered at all this will effectly make visible fade not work when IsVisible returns false.
A potential fix for this would be to add Visible = visibleFade > 0f; right after the visibleFade is updated.
See steps to reproduce to see differences when fix is applied with exaggerated fade time.

Steps to Reproduce

bugged.webm
fixed.webm

Log Output

No response

@Sarrg Sarrg added the bug Something isn't working label Nov 27, 2024
@Sarrg
Copy link
Author

Sarrg commented Nov 27, 2024

On further notice, it seems that visibleFade then need to be initialized with 0f.
On startup this then again has the effect that it is instantly visible since it takes a while before the full screen is visible anyway.
Sadly upon screen transitioning this would cause a fade-in, not sure if this is the case for all Backdrops.
To circumvent that one could either do a late init on the first update.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant