Use Common paths for Build, Publish and Pack

The new Output paths point to...

Build: `~build\{bin,obj}`
Restore: `~build\ext`
Publish: `~publish\...`
Pack: `~packages\{bin,obj}`

Also, Fix logic in Update-Header.ps1 to exclude new paths
from the list of sources files that works across platforms.

Author: Nirmal4G

.gitignore

@@ -8,6 +8,10 @@
 *.userosscache
 *.sln.docstates
 
+# Working folders
+~build/
+~publish/
+
 # Build results
 [Bb]in/
 [Oo]bj/

Directory.Build.props

@@ -1,5 +1,7 @@
 <Project>
 
+  <Import Project="Directory.Solution.props" />
+
   <PropertyGroup>
     <RepositoryDirectory>$(MSBuildThisFileDirectory)</RepositoryDirectory>
     <BuildToolsDirectory>$(RepositoryDirectory)build\</BuildToolsDirectory>
@@ -11,7 +13,6 @@
     <When Condition="$(IsCoreProject)">
       <PropertyGroup>
         <GenerateDocumentationFile>true</GenerateDocumentationFile>
-        <PackageOutputPath>$(RepositoryDirectory)bin\nupkg</PackageOutputPath>
         <TreatWarningsAsErrors Condition="'$(Configuration)' == 'Release'">true</TreatWarningsAsErrors>
       </PropertyGroup>
     </When>

Directory.Solution.props

@@ -0,0 +1,7 @@
+<Project>
+
+  <PropertyGroup>
+    <RestoreUseStaticGraphEvaluation>True</RestoreUseStaticGraphEvaluation>
+  </PropertyGroup>
+
+</Project>

azure-pipelines.yml

@@ -72,10 +72,10 @@ jobs:
     env:
       SignClientUser: $(SignClientUser)
       SignClientSecret: $(SignClientSecret)
-      ArtifactDirectory: bin/nupkg
+      ArtifactDirectory: ~packages/bin
     condition: and(succeeded(), not(eq(variables['Build.Reason'], 'PullRequest')), not(eq(variables['SignClientSecret'], '')), not(eq(variables['SignClientUser'], '')))
 
   # Publish build artifacts
-  - publish: bin/nupkg
+  - publish: ~packages/bin
     artifact: Packages
     displayName: Publish package artifacts

build/Community.Toolkit.Common.props

@@ -1,24 +1,24 @@
 <Project>
 
-  <PropertyGroup>
+  <PropertyGroup Label="Compile">
     <Features>Strict</Features>
     <Nullable>Enable</Nullable>
     <LangVersion>Latest</LangVersion>
     <AllowUnsafeBlocks>true</AllowUnsafeBlocks>
   </PropertyGroup>
 
-  <PropertyGroup>
+  <PropertyGroup Label="Assembly">
     <SignAssembly>true</SignAssembly>
     <AssemblyOriginatorKeyFile>$(RepositoryDirectory)toolkit.snk</AssemblyOriginatorKeyFile>
   </PropertyGroup>
 
-  <PropertyGroup>
+  <PropertyGroup Label="Project">
     <IsTestProject>$(MSBuildProjectName.EndsWith('Tests'))</IsTestProject>
     <IsCoreProject Condition="$(IsTestProject)">False</IsCoreProject>
     <IsCoreProject Condition="'$(IsCoreProject)' == ''">True</IsCoreProject>
   </PropertyGroup>
 
-  <PropertyGroup>
+  <PropertyGroup Label="Build">
     <IsPackable>true</IsPackable>
     <IsPublishable>true</IsPublishable>
     <ContinuousIntegrationBuild>$(TF_BUILD)</ContinuousIntegrationBuild>
@@ -31,4 +31,19 @@
     </PackageFile>
   </ItemDefinitionGroup>
 
+  <PropertyGroup Label="Outputs">
+    <!-- Common Outputs -->
+    <BuildDir>~build\</BuildDir>
+    <PublishDir>~publish\</PublishDir>
+    <!-- Build Outputs -->
+    <BaseOutputPath>$(BuildDir)bin\</BaseOutputPath>
+    <BaseIntermediateOutputPath>$(BuildDir)obj\</BaseIntermediateOutputPath>
+    <!-- Restore Outputs-->
+    <MSBuildProjectExtensionsPath>$(BuildDir)ext\</MSBuildProjectExtensionsPath>
+    <RestoreOutputPath>$(MSBuildProjectExtensionsPath)</RestoreOutputPath>
+    <!-- Pack Outputs -->
+    <PackageOutputPath>$(RepositoryDirectory)~packages\bin\</PackageOutputPath>
+    <NuSpecOutputPath>$(RepositoryDirectory)~packages\obj\</NuSpecOutputPath>
+  </PropertyGroup>
+
 </Project>

build/Community.Toolkit.Common.targets

@@ -25,6 +25,11 @@
     <PackageFile Include="$(RepositoryDirectory)ThirdPartyNotices.txt" />
   </ItemGroup>
 
+  <!-- Exclude files and folders from build and publish across all projects -->
+  <PropertyGroup>
+    <DefaultItemExcludes>$(BuildDir)**;$(PublishDir)**;$(DefaultItemExcludes)</DefaultItemExcludes>
+  </PropertyGroup>
+
   <!--
       Use 'GenerateNuSpecDependsOn' extensibility point to include custom global assets in the package.
       Use 'TargetsForTfmSpecificContentInPackage' extensibility point to include custom TFM-specific assets in the package.

build/Update-Headers.ps1

@@ -1,7 +1,7 @@
 # Script to Update Header comment in C# sources within this repository.
 
 # This script duplicates the fuctionality provided by the 'UpdateHeaders' target in Cake script present previously.
-# Since, Cake build has been removed, this fuctionality has been implimented here in this PowerShell script.
+# Since, Cake build has been removed, this fuctionality has been implemented here in this PowerShell script.
 
 [CmdletBinding()]
 Param(
@@ -33,7 +33,18 @@ function Get-SourceFiles ([string]$Path, [string]$Extension) {
     $fileFilter = "*.$fileType"
     $fileExcludes = "*.g.$fileType", "*.i.$fileType", "*TemporaryGeneratedFile*.$fileType"
     $sourceFiles = Get-ChildItem -Path $Path -File -Recurse -Filter $fileFilter -Exclude $fileExcludes
-    return $sourceFiles.Where({ !($_.FullName.Contains("\bin\") -or $_.FullName.Contains("\obj\")) })
+
+    $folderExcludes = "build", "~build", "~publish", "~packages", "bin", "obj"
+
+    return $sourceFiles.Where({
+        foreach ($folder in $folderExcludes) {
+            $folderPattern = "{0}$folder{0}" -f [IO.Path]::DirectorySeparatorChar
+            if ($_.FullName.Contains($folderPattern)) {
+                return $false
+            }
+        }
+        return $true
+    })
 }
 
 # Set Repot Root