Add compare function for YearMonth and fix filtering of expired identities

Author: limemloh

packages/browser-wallet/src/popup/popupX/pages/CreateAccount/CreateAccount.tsx

@@ -9,6 +9,7 @@ import { ConfirmedIdCard } from '@popup/popupX/shared/IdCard';
 import Button from '@popup/popupX/shared/Button';
 import { generatePath, useNavigate } from 'react-router-dom';
 import { absoluteRoutes } from '@popup/popupX/constants/routes';
+import { compareYearMonth, getCurrentYearMonth } from 'wallet-common-helpers';
 
 /**
  * Get the valid identities, which is Identities that are confirmed by the ID provider and are not
@@ -19,13 +20,14 @@ import { absoluteRoutes } from '@popup/popupX/constants/routes';
 function useValidIdentities(): ConfirmedIdentity[] {
     const identities = useAtomValue(identitiesAtom);
     return useMemo(() => {
-        const now = new Date();
+        const now = getCurrentYearMonth();
         return identities.flatMap((id) => {
             if (id.status !== CreationStatus.Confirmed) {
                 return [];
             }
-            const validToDate = new Date(id.idObject.value.attributeList.validTo);
-            if (validToDate < now) {
+            // Negative number is indicating that `validTo` is before `now`, therefore expired.
+            const isExpired = compareYearMonth(id.idObject.value.attributeList.validTo, now) < 0;
+            if (isExpired) {
                 return [];
             }
             return [id];

packages/browser-wallet/src/wallet-common-helpers/utils/timeHelpers.ts

@@ -55,6 +55,32 @@ export function getCurrentYearMonth(): YearMonth {
     return date.getFullYear() + month;
 }
 
+/**
+ * Function comparing two YearMonth strings.
+ *
+ * Returns a number where:
+ *
+ * - A negative value indicates that `left` is before `right`.
+ * - A positive value indicates that `left` is after `right`.
+ * - Zero indicates that `left` and `right` are equal.
+ */
+export function compareYearMonth(left: YearMonth, right: YearMonth): number {
+    const leftYear = parseInt(left.slice(0, 4), 10);
+    const rightYear = parseInt(right.slice(0, 4), 10);
+    if (Number.isNaN(leftYear) || Number.isNaN(rightYear)) {
+        throw new Error('Invalid input for compareYearMonth, unable to parse integer representing the year');
+    }
+    if (leftYear !== rightYear) {
+        return leftYear - rightYear;
+    }
+    const leftMonth = parseInt(left.slice(4, 6), 10);
+    const rightMonth = parseInt(right.slice(4, 6), 10);
+    if (Number.isNaN(leftMonth) || Number.isNaN(rightMonth)) {
+        throw new Error('Invalid input for compareYearMonth, unable to parse integer representing the month');
+    }
+    return leftMonth - rightMonth;
+}
+
 /**
  * Converts a unix timestamp to a Date type.
  * @param timestamp the unix timestamp, in seconds or milliseconds.