Merge pull request #477 from Concordium/fix-block-metrics-avg-fin-time

limemloh · web-flow · commit f98931c584d8 · 2025-02-07T08:50:50.000+01:00
Only consider blocks where we know finalization time in block_metrics
diff --git a/backend-rust/.sqlx/query-9017d71491699344844fd5d01607e599cc54530c4b78fc2b3b5859670d9c0400.json b/backend-rust/.sqlx/query-9017d71491699344844fd5d01607e599cc54530c4b78fc2b3b5859670d9c0400.json
diff --git a/backend-rust/CHANGELOG.md b/backend-rust/CHANGELOG.md
@@ -25,10 +25,10 @@ Database schema version: 2
 - Fix typo in `versions` endpoint.
 - Fix unit conversion for `avg_finalization_time` in `Query::block_metrics`.
 - Issue for `Query::transaction_metrics` producing an internal error when query period is beyond the genesis block.
-- Next and previous page on contracts
-- Contract rejected event skips in the correct way
+- Next and previous page on contracts.
+- Contract rejected event skips in the correct way.
 - Fix issue where `ContractUpdated::message` attempted to parse empty messages, resulting in parsing error messages instead of `null`.
-
+- Issue making `avgFinalizationTime` field of `Query::block_metrics` always return `null`.
 
 ## [0.1.19] - 2025-01-30
 
diff --git a/backend-rust/src/graphql_api/block_metrics.rs b/backend-rust/src/graphql_api/block_metrics.rs
@@ -126,6 +126,7 @@ impl QueryBlockMetrics {
                          slot_time,
                          cumulative_finalization_time
                      FROM blocks
+                     WHERE cumulative_finalization_time IS NOT NULL
                      ORDER BY slot_time DESC
                      LIMIT 1
                  )

Original file line number	Diff line number	Diff line change
`@@ -126,6 +126,7 @@ impl QueryBlockMetrics {`
`126`	`126`	`slot_time,`
`127`	`127`	`cumulative_finalization_time`
`128`	`128`	`FROM blocks`
	`129`	`+ WHERE cumulative_finalization_time IS NOT NULL`
`129`	`130`	`ORDER BY slot_time DESC`
`130`	`131`	`LIMIT 1`
`131`	`132`	`)`