Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Add more data type support for key #185

Open
jaredzhou opened this issue Jul 30, 2024 · 3 comments
Open

Feature: Add more data type support for key #185

jaredzhou opened this issue Jul 30, 2024 · 3 comments
Labels
feature New feature or request

Comments

@jaredzhou
Copy link

Feature description

this pg connector only support int type key for table for now , i don't see the reason, i think other type like varchar is possible, and it's common to use uuid or varchar as primary key

@jaredzhou jaredzhou added feature New feature or request triage Needs to be triaged labels Jul 30, 2024
@lovromazgon
Copy link
Member

We currently don't support them because we were focusing on making it possible to do an incremental snapshot (i.e. if the snapshot is interrupted we don't have to start the snapshot again from scratch). This is specifically important for huge tables where the snapshot can take hours or even days. That's why we currently have the restriction for keys to be an ordinal type that's auto-incremented. However, we do plan to add support for other types, with the caveat of not being able to do an incremental snapshot.

@jaredzhou
Copy link
Author

that make sense, glad to see the support for varchar.

@lovromazgon
Copy link
Member

I realized that you can still use the connector to move data continuously using logical replication (CDC), the restriction on the primary key type only applies to snapshots.

@lovromazgon lovromazgon removed the triage Needs to be triaged label Aug 5, 2024
@github-project-automation github-project-automation bot moved this to Triage in Conduit Main Feb 8, 2025
@raulb raulb removed the status in Conduit Main Feb 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or request
Projects
Status: No status
Development

No branches or pull requests

2 participants