Skip to content

Clarify default and allowed values of batching parameters #310

@hariso

Description

@hariso

Feature description

This started in a conversation about a previous PR.

Currently, a non-zero batch size or delay is used to indicate that batching should be enabled:

if *s.config.BatchSize > 0 || *s.config.BatchDelay > 0 {

However, that seems a bit counterintuitive. From a user's point of view:

  • Any value that is less than 1 doesn't make sense as a batch size.
  • A batch that always has a size of 1 means that there's no batching.
  • A value ≥2 means that batching should happen.

Metadata

Metadata

Assignees

No one assigned

    Labels

    featureNew feature or request

    Type

    No type

    Projects

    Status

    No status

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions