Skip to content

Commit

Permalink
[Fix] Remove dead code for finalized-tag-updater-github-release.yml a…
Browse files Browse the repository at this point in the history
…utomatic trigger (#506)

* removed commented out code + automatic trigger for finalized-tag-updated-github-release

* removed dead references to finalized-tag-updater in main.yml
  • Loading branch information
kyzooghost authored Jan 9, 2025
1 parent 35a8ded commit 94f461a
Show file tree
Hide file tree
Showing 2 changed files with 0 additions and 24 deletions.
6 changes: 0 additions & 6 deletions .github/workflows/finalized-tag-updater-github-release.yml
Original file line number Diff line number Diff line change
@@ -1,11 +1,5 @@
name: Github Release for Finalized-Tag-Updater Besu Plugin
on:
workflow_call:
inputs:
version:
required: true
type: string

workflow_dispatch:
inputs:
version:
Expand Down
18 changes: 0 additions & 18 deletions .github/workflows/main.yml
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,6 @@ jobs:
prover: ${{ steps.filter.outputs.prover }}
traces-api-facade: ${{ steps.filter.outputs.traces-api-facade }}
transaction-exclusion-api: ${{ steps.filter.outputs.transaction-exclusion-api }}
finalized-tag-updater: ${{ steps.filter.outputs.finalized-tag-updater }}
has-changes-requiring-build: ${{ steps.filter-out.outputs.has-changes-requiring-build }}
steps:
- name: Checkout
Expand Down Expand Up @@ -105,14 +104,6 @@ jobs:
- 'build.gradle'
- 'gradle.properties'
- 'settings.gradle'
finalized-tag-updater:
- 'jvm-libs/linea/core/long-running-service/**'
- 'jvm-libs/linea/web3j-extensions/**'
- 'jvm-libs/extensions/kotlin/**'
- 'jvm-libs/extensions/futures/**'
- 'finalized-tag-updater/**'
- '.github/workflows/main.yml'
- '.github/workflows/finalized-tag-updater-github-release.yml'
- name: Filter out commit changes
uses: dorny/paths-filter@v3
id: filter-out
Expand Down Expand Up @@ -174,15 +165,6 @@ jobs:
transaction_exclusion_api_image_tagged: ${{ needs.check-and-tag-images.outputs.image_tagged_transaction_exclusion_api }}
secrets: inherit

# Comment out the auto build and release step below as the plugin release should be
# by manual Github action for versioning control
# finalized-tag-updater-jar-build-release:
# needs: [ filter-commit-changes ]
# if: ${{ always() && needs.filter-commit-changes.outputs.finalized-tag-updater == 'true' }}
# uses: ./.github/workflows/finalized-tag-updater-github-release.yml
# with:
# version: '0.0.1'

testing:
needs: [ store-image-name-and-tags, filter-commit-changes, check-and-tag-images ]
if: ${{ always() && needs.filter-commit-changes.outputs.has-changes-requiring-build == 'true' }}
Expand Down

0 comments on commit 94f461a

Please sign in to comment.