Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix new compile + test warnings for Openzeppelin plugin & Solhint #679

Open
3 of 6 tasks
kyzooghost opened this issue Feb 12, 2025 · 0 comments
Open
3 of 6 tasks
Assignees
Labels
Contracts Smart Contract related P2: Medium Issue priority: medium

Comments

@kyzooghost
Copy link
Contributor

kyzooghost commented Feb 12, 2025

Description

After #656 was merged where we updated the versions of multiple contract dependencies including Solhint and @openzeppelin/upgrades-core, we have had a bunch of new warnings emerge in contract compilation, tests and linting. We would like to address these new warnings.

Motivation

Better developer UX with less warnings, also more aligned with current 'best practices'

Tasks

  • Address Solhint and warnings

Acceptance criteria

  • Passing CI

Risks

  • Break CI

Remember to

  • Add the documentation label in case there is an impact on the documentation
  • Add priority and team labels
  • Add Task for updating the Runbook or adding/updating existing metrics and alerts.
@kyzooghost kyzooghost added Contracts Smart Contract related P2: Medium Issue priority: medium labels Feb 12, 2025
@kyzooghost kyzooghost self-assigned this Feb 12, 2025
@kyzooghost kyzooghost changed the title Copy of Refactor TokenBridge to use transient storage for the ReentrancyGuard implementation Fix new compile + test warnings for Openzeppelin plugin & Solhint Feb 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Contracts Smart Contract related P2: Medium Issue priority: medium
Projects
None yet
Development

No branches or pull requests

1 participant