-
Notifications
You must be signed in to change notification settings - Fork 72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove the EIP-4844 Toggle From Decompression Circuit #714
Closed
Tabaie
wants to merge
9
commits into
chore/delete-compression-v0
from
prover/chore/remove-eip4844-toggle
Closed
Remove the EIP-4844 Toggle From Decompression Circuit #714
Tabaie
wants to merge
9
commits into
chore/delete-compression-v0
from
prover/chore/remove-eip4844-toggle
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## chore/delete-compression-v0 #714 +/- ##
==============================================================
Coverage 68.40% 68.40%
Complexity 1185 1185
==============================================================
Files 323 323
Lines 13131 13131
Branches 1319 1319
==============================================================
Hits 8982 8982
Misses 3597 3597
Partials 552 552
*This pull request uses carry forward flags. Click here to find out more. |
Closing as the "calldata" (EIP-4844 = false) feature is still needed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This can reduce the maximum blob size by 9.16 KB (from 793217 B to 802594 B) or open space for the execution data polynomial check