Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the EIP-4844 Toggle From Decompression Circuit #714

Closed

Conversation

Tabaie
Copy link
Contributor

@Tabaie Tabaie commented Feb 19, 2025

This can reduce the maximum blob size by 9.16 KB (from 793217 B to 802594 B) or open space for the execution data polynomial check

@Tabaie Tabaie had a problem deploying to docker-build-and-e2e February 19, 2025 23:37 — with GitHub Actions Error
@Tabaie Tabaie changed the base branch from main to chore/delete-compression-v0 February 19, 2025 23:37
@codecov-commenter
Copy link

codecov-commenter commented Feb 19, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 68.40%. Comparing base (5d65908) to head (bad3e7e).

Additional details and impacted files
@@                      Coverage Diff                       @@
##             chore/delete-compression-v0     #714   +/-   ##
==============================================================
  Coverage                          68.40%   68.40%           
  Complexity                          1185     1185           
==============================================================
  Files                                323      323           
  Lines                              13131    13131           
  Branches                            1319     1319           
==============================================================
  Hits                                8982     8982           
  Misses                              3597     3597           
  Partials                             552      552           
Flag Coverage Δ *Carryforward flag
hardhat 98.52% <ø> (ø)
kotlin 66.05% <ø> (ø) Carriedforward from f5fc2f1

*This pull request uses carry forward flags. Click here to find out more.

@Tabaie Tabaie had a problem deploying to docker-build-and-e2e February 19, 2025 23:42 — with GitHub Actions Error
@Tabaie Tabaie had a problem deploying to docker-build-and-e2e February 19, 2025 23:54 — with GitHub Actions Error
@Tabaie Tabaie had a problem deploying to docker-build-and-e2e February 20, 2025 00:03 — with GitHub Actions Error
@Tabaie Tabaie had a problem deploying to docker-build-and-e2e February 20, 2025 15:53 — with GitHub Actions Error
@Tabaie Tabaie had a problem deploying to docker-build-and-e2e February 21, 2025 20:10 — with GitHub Actions Error
@Tabaie Tabaie requested a deployment to docker-build-and-e2e February 22, 2025 15:20 — with GitHub Actions Waiting
@Tabaie
Copy link
Contributor Author

Tabaie commented Feb 24, 2025

Closing as the "calldata" (EIP-4844 = false) feature is still needed

@Tabaie Tabaie closed this Feb 24, 2025
@Tabaie Tabaie deleted the prover/chore/remove-eip4844-toggle branch February 24, 2025 20:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants