refactoring

Author: thomaslule

src/fixed-footnotes.js

@@ -92,36 +92,40 @@ FixedFootnotes.prototype.removeRefreshListener = function(listener) {
  * From here: "private" methods that user is not supposed to call directly.
  */
 
+/*
+ * Create the fixed container that will host the footnotes.
+ */
+FixedFootnotes.prototype._createFixedContainer = function() {
+  var fixedContainer = this._window.document.createElement("div");
+  fixedContainer.id = this.options.fixedContainerId;
+  fixedContainer.className = this.options.fixedContainerClass + " fixed-footnotes-empty";
+  fixedContainer.appendChild(this._window.document.createElement("ul"));
+  this._window.document.querySelector(this.options.fixedContainerLocation).appendChild(fixedContainer);
+  return fixedContainer;
+}
+
 /*
  * Refresh the view.
  */
 FixedFootnotes.prototype._refreshView = function() {
   var self = this;
   util.emptyElement(this._fixedContainerList);
-  this._fixedContainer.className = this.options.fixedContainerClass + " fixed-footnotes-empty";
+  var containerEmpty = true;
   this._getReferences().forEach(function(reference) {
     var note = self._getNoteFromRef(reference);
-    if (!note) return;
-    if (util.isElementInViewport(reference, self._window) && !util.isElementInViewport(note, self._window)) {
+    if (self._shouldDisplayNoteFor(reference, note)) {
       self._displayNote(note);
-      self._fixedContainer.className = self.options.fixedContainerClass;
+      containerEmpty = false;
     }
   });
+  if (containerEmpty) {
+    this._fixedContainer.classList.add("fixed-footnotes-empty");
+  } else {
+    this._fixedContainer.classList.remove("fixed-footnotes-empty");
+  }
   this._dispatchRefresh();
 };
 
-/*
- * Create the fixed container that will host the footnotes.
- */
-FixedFootnotes.prototype._createFixedContainer = function() {
-  var fixedContainer = this._window.document.createElement("div");
-  fixedContainer.id = this.options.fixedContainerId;
-  fixedContainer.className = this.options.fixedContainerClass + " fixed-footnotes-empty";
-  fixedContainer.appendChild(this._window.document.createElement("ul"));
-  this._window.document.querySelector(this.options.fixedContainerLocation).appendChild(fixedContainer);
-  return fixedContainer;
-}
-
 /*
  * Get all the references.
  */
@@ -130,11 +134,13 @@ FixedFootnotes.prototype._getReferences = function() {
 };
 
 /*
- * Given a reference, display the footnote in the fixed container if the reference is on screen.
- * It won't display the footnote in the fixed container if the footnote is already on screen.
+ * Return true if we should display the note of the given reference.
+ * Note must exist, reference must be visible, and original note must not be visible.
  */
-FixedFootnotes.prototype._displayIfVisible = function(reference) {
-
+FixedFootnotes.prototype._shouldDisplayNoteFor = function(reference, note) {
+  return note != undefined &&
+    util.isElementInViewport(reference, this._window) &&
+    !util.isElementInViewport(note, this._window);
 };
 
 /*