Skip to content

Commit 0db5945

Browse files
committed
Remove canonical_length parameter
1 parent 8fae0cf commit 0db5945

File tree

9 files changed

+75
-74
lines changed

9 files changed

+75
-74
lines changed

contracts/burner/src/contract.rs

+2-2
Original file line numberDiff line numberDiff line change
@@ -75,7 +75,7 @@ mod tests {
7575

7676
#[test]
7777
fn init_fails() {
78-
let mut deps = mock_dependencies(20, &[]);
78+
let mut deps = mock_dependencies(&[]);
7979

8080
let msg = InitMsg {};
8181
let env = mock_env("creator", &coins(1000, "earth"));
@@ -91,7 +91,7 @@ mod tests {
9191

9292
#[test]
9393
fn migrate_cleans_up_data() {
94-
let mut deps = mock_dependencies(20, &coins(123456, "gold"));
94+
let mut deps = mock_dependencies(&coins(123456, "gold"));
9595

9696
// store some sample data
9797
deps.storage.set(b"foo", b"bar");

contracts/hackatom/src/contract.rs

+9-9
Original file line numberDiff line numberDiff line change
@@ -373,7 +373,7 @@ mod tests {
373373

374374
#[test]
375375
fn proper_initialization() {
376-
let mut deps = mock_dependencies(20, &[]);
376+
let mut deps = mock_dependencies(&[]);
377377

378378
let verifier = HumanAddr(String::from("verifies"));
379379
let beneficiary = HumanAddr(String::from("benefits"));
@@ -403,7 +403,7 @@ mod tests {
403403

404404
#[test]
405405
fn init_and_query() {
406-
let mut deps = mock_dependencies(20, &[]);
406+
let mut deps = mock_dependencies(&[]);
407407

408408
let verifier = HumanAddr(String::from("verifies"));
409409
let beneficiary = HumanAddr(String::from("benefits"));
@@ -423,7 +423,7 @@ mod tests {
423423

424424
#[test]
425425
fn migrate_verifier() {
426-
let mut deps = mock_dependencies(20, &[]);
426+
let mut deps = mock_dependencies(&[]);
427427

428428
let verifier = HumanAddr::from("verifies");
429429
let beneficiary = HumanAddr::from("benefits");
@@ -458,7 +458,7 @@ mod tests {
458458
fn querier_callbacks_work() {
459459
let rich_addr = HumanAddr::from("foobar");
460460
let rich_balance = coins(10000, "gold");
461-
let deps = mock_dependencies_with_balances(20, &[(&rich_addr, &rich_balance)]);
461+
let deps = mock_dependencies_with_balances(&[(&rich_addr, &rich_balance)]);
462462

463463
// querying with balance gets the balance
464464
let bal = query_other_balance(&deps, rich_addr).unwrap();
@@ -471,7 +471,7 @@ mod tests {
471471

472472
#[test]
473473
fn handle_release_works() {
474-
let mut deps = mock_dependencies(20, &[]);
474+
let mut deps = mock_dependencies(&[]);
475475

476476
// initialize the store
477477
let creator = HumanAddr::from("creator");
@@ -514,7 +514,7 @@ mod tests {
514514

515515
#[test]
516516
fn handle_release_fails_for_wrong_sender() {
517-
let mut deps = mock_dependencies(20, &[]);
517+
let mut deps = mock_dependencies(&[]);
518518

519519
// initialize the store
520520
let creator = HumanAddr::from("creator");
@@ -558,7 +558,7 @@ mod tests {
558558
#[test]
559559
#[should_panic(expected = "This page intentionally faulted")]
560560
fn handle_panic() {
561-
let mut deps = mock_dependencies(20, &[]);
561+
let mut deps = mock_dependencies(&[]);
562562

563563
// initialize the store
564564
let verifier = HumanAddr(String::from("verifies"));
@@ -580,7 +580,7 @@ mod tests {
580580

581581
#[test]
582582
fn handle_user_errors_in_api_calls() {
583-
let mut deps = mock_dependencies(20, &[]);
583+
let mut deps = mock_dependencies(&[]);
584584

585585
let init_msg = InitMsg {
586586
verifier: HumanAddr::from("verifies"),
@@ -599,7 +599,7 @@ mod tests {
599599
// the test framework doesn't handle contracts querying contracts yet,
600600
// let's just make sure the last step looks right
601601

602-
let deps = mock_dependencies(20, &[]);
602+
let deps = mock_dependencies(&[]);
603603
let contract = HumanAddr::from("my-contract");
604604
let bin_contract: &[u8] = b"my-contract";
605605

contracts/queue/src/contract.rs

+1-1
Original file line numberDiff line numberDiff line change
@@ -207,7 +207,7 @@ mod tests {
207207
use cosmwasm_std::{coins, from_binary};
208208

209209
fn create_contract() -> (Extern<MockStorage, MockApi, MockQuerier>, Env) {
210-
let mut deps = mock_dependencies(20, &coins(1000, "earth"));
210+
let mut deps = mock_dependencies(&coins(1000, "earth"));
211211
let env = mock_env("creator", &coins(1000, "earth"));
212212
let res = init(&mut deps, env.clone(), InitMsg {}).unwrap();
213213
assert_eq!(0, res.messages.len());

contracts/reflect/src/contract.rs

+16-14
Original file line numberDiff line numberDiff line change
@@ -144,7 +144,7 @@ mod tests {
144144

145145
#[test]
146146
fn proper_initialization() {
147-
let mut deps = mock_dependencies_with_custom_querier(20, &[]);
147+
let mut deps = mock_dependencies_with_custom_querier(&[]);
148148

149149
let msg = InitMsg {};
150150
let env = mock_env("creator", &coins(1000, "earth"));
@@ -160,7 +160,7 @@ mod tests {
160160

161161
#[test]
162162
fn reflect() {
163-
let mut deps = mock_dependencies_with_custom_querier(20, &[]);
163+
let mut deps = mock_dependencies_with_custom_querier(&[]);
164164

165165
let msg = InitMsg {};
166166
let env = mock_env("creator", &coins(2, "token"));
@@ -183,7 +183,7 @@ mod tests {
183183

184184
#[test]
185185
fn reflect_requires_owner() {
186-
let mut deps = mock_dependencies_with_custom_querier(20, &[]);
186+
let mut deps = mock_dependencies_with_custom_querier(&[]);
187187

188188
let msg = InitMsg {};
189189
let env = mock_env("creator", &coins(2, "token"));
@@ -210,7 +210,7 @@ mod tests {
210210

211211
#[test]
212212
fn reflect_reject_empty_msgs() {
213-
let mut deps = mock_dependencies_with_custom_querier(20, &[]);
213+
let mut deps = mock_dependencies_with_custom_querier(&[]);
214214

215215
let msg = InitMsg {};
216216
let env = mock_env("creator", &coins(2, "token"));
@@ -231,7 +231,7 @@ mod tests {
231231

232232
#[test]
233233
fn reflect_multiple_messages() {
234-
let mut deps = mock_dependencies_with_custom_querier(20, &[]);
234+
let mut deps = mock_dependencies_with_custom_querier(&[]);
235235

236236
let msg = InitMsg {};
237237
let env = mock_env("creator", &coins(2, "token"));
@@ -264,7 +264,7 @@ mod tests {
264264

265265
#[test]
266266
fn change_owner_works() {
267-
let mut deps = mock_dependencies_with_custom_querier(20, &[]);
267+
let mut deps = mock_dependencies_with_custom_querier(&[]);
268268

269269
let msg = InitMsg {};
270270
let env = mock_env("creator", &coins(2, "token"));
@@ -285,13 +285,15 @@ mod tests {
285285

286286
#[test]
287287
fn change_owner_requires_current_owner_as_sender() {
288-
let mut deps = mock_dependencies_with_custom_querier(20, &[]);
288+
let mut deps = mock_dependencies_with_custom_querier(&[]);
289289

290290
let msg = InitMsg {};
291-
let env = mock_env("creator", &coins(2, "token"));
291+
let creator = HumanAddr::from("creator");
292+
let env = mock_env(creator.clone(), &coins(2, "token"));
292293
let _res = init(&mut deps, env, msg).unwrap();
293294

294-
let env = mock_env("random", &[]);
295+
let random = HumanAddr::from("random");
296+
let env = mock_env(random.clone(), &[]);
295297
let new_owner = HumanAddr::from("friend");
296298
let msg = HandleMsg::ChangeOwner {
297299
owner: new_owner.clone(),
@@ -300,16 +302,16 @@ mod tests {
300302
let res = handle(&mut deps, env, msg);
301303
match res.unwrap_err() {
302304
ReflectError::NotCurrentOwner { expected, actual } => {
303-
assert_eq!(expected.as_slice(), b"creator\0\0\0\0\0\0\0\0\0\0\0\0\0");
304-
assert_eq!(actual.as_slice(), b"random\0\0\0\0\0\0\0\0\0\0\0\0\0\0");
305+
assert_eq!(expected, deps.api.canonical_address(&creator).unwrap());
306+
assert_eq!(actual, deps.api.canonical_address(&random).unwrap());
305307
}
306308
err => panic!("Unexpected error: {:?}", err),
307309
}
308310
}
309311

310312
#[test]
311313
fn change_owner_errors_for_invalid_new_address() {
312-
let mut deps = mock_dependencies_with_custom_querier(20, &[]);
314+
let mut deps = mock_dependencies_with_custom_querier(&[]);
313315
let creator = HumanAddr::from("creator");
314316

315317
let msg = InitMsg {};
@@ -331,7 +333,7 @@ mod tests {
331333

332334
#[test]
333335
fn capitalized_query_works() {
334-
let deps = mock_dependencies_with_custom_querier(20, &[]);
336+
let deps = mock_dependencies_with_custom_querier(&[]);
335337

336338
let msg = QueryMsg::Capitalized {
337339
text: "demo one".to_string(),
@@ -343,7 +345,7 @@ mod tests {
343345

344346
#[test]
345347
fn chain_query_works() {
346-
let deps = mock_dependencies_with_custom_querier(20, &coins(123, "ucosm"));
348+
let deps = mock_dependencies_with_custom_querier(&coins(123, "ucosm"));
347349

348350
// with bank query
349351
let msg = QueryMsg::Chain {

contracts/reflect/src/testing.rs

+2-3
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,6 @@ use cosmwasm_std::{to_binary, Binary, Coin, ContractResult, Extern, HumanAddr, S
66
/// A drop-in replacement for cosmwasm_std::testing::mock_dependencies
77
/// this uses our CustomQuerier.
88
pub fn mock_dependencies_with_custom_querier(
9-
canonical_length: usize,
109
contract_balance: &[Coin],
1110
) -> Extern<MockStorage, MockApi, MockQuerier<SpecialQuery>> {
1211
let contract_addr = HumanAddr::from(MOCK_CONTRACT_ADDR);
@@ -15,7 +14,7 @@ pub fn mock_dependencies_with_custom_querier(
1514
.with_custom_handler(|query| SystemResult::Ok(custom_query_execute(&query)));
1615
Extern {
1716
storage: MockStorage::default(),
18-
api: MockApi::new(canonical_length),
17+
api: MockApi::default(),
1918
querier: custom_querier,
2019
}
2120
}
@@ -52,7 +51,7 @@ mod test {
5251

5352
#[test]
5453
fn custom_querier() {
55-
let deps = mock_dependencies_with_custom_querier(20, &[]);
54+
let deps = mock_dependencies_with_custom_querier(&[]);
5655
let req: QueryRequest<_> = SpecialQuery::Capitalized {
5756
text: "food".to_string(),
5857
}

contracts/reflect/tests/integration.rs

+2-3
Original file line numberDiff line numberDiff line change
@@ -42,7 +42,6 @@ static WASM: &[u8] = include_bytes!("../target/wasm32-unknown-unknown/release/re
4242
/// A drop-in replacement for cosmwasm_vm::testing::mock_dependencies
4343
/// that supports SpecialQuery.
4444
pub fn mock_dependencies_with_custom_querier(
45-
canonical_length: usize,
4645
contract_balance: &[Coin],
4746
) -> Extern<MockStorage, MockApi, MockQuerier<SpecialQuery>> {
4847
let contract_addr = HumanAddr::from(MOCK_CONTRACT_ADDR);
@@ -52,7 +51,7 @@ pub fn mock_dependencies_with_custom_querier(
5251

5352
Extern {
5453
storage: MockStorage::default(),
55-
api: MockApi::new(canonical_length),
54+
api: MockApi::default(),
5655
querier: custom_querier,
5756
}
5857
}
@@ -177,7 +176,7 @@ fn transfer_requires_owner() {
177176
#[test]
178177
fn dispatch_custom_query() {
179178
// stub gives us defaults. Consume it and override...
180-
let custom = mock_dependencies_with_custom_querier(20, &[]);
179+
let custom = mock_dependencies_with_custom_querier(&[]);
181180
// we cannot use mock_instance, so we just copy and modify code from cosmwasm_vm::testing
182181
let mut deps = Instance::from_code(WASM, custom, 500_000, false).unwrap();
183182

contracts/staking/src/contract.rs

+6-6
Original file line numberDiff line numberDiff line change
@@ -509,7 +509,7 @@ mod tests {
509509

510510
#[test]
511511
fn initialization_with_missing_validator() {
512-
let mut deps = mock_dependencies(20, &[]);
512+
let mut deps = mock_dependencies(&[]);
513513
deps.querier
514514
.update_staking("ustake", &[sample_validator("john")], &[]);
515515

@@ -536,7 +536,7 @@ mod tests {
536536

537537
#[test]
538538
fn proper_initialization() {
539-
let mut deps = mock_dependencies(20, &[]);
539+
let mut deps = mock_dependencies(&[]);
540540
deps.querier.update_staking(
541541
"ustake",
542542
&[
@@ -587,7 +587,7 @@ mod tests {
587587

588588
#[test]
589589
fn bonding_issues_tokens() {
590-
let mut deps = mock_dependencies(20, &[]);
590+
let mut deps = mock_dependencies(&[]);
591591
set_validator(&mut deps.querier);
592592

593593
let creator = HumanAddr::from("creator");
@@ -627,7 +627,7 @@ mod tests {
627627

628628
#[test]
629629
fn rebonding_changes_pricing() {
630-
let mut deps = mock_dependencies(20, &[]);
630+
let mut deps = mock_dependencies(&[]);
631631
set_validator(&mut deps.querier);
632632

633633
let creator = HumanAddr::from("creator");
@@ -687,7 +687,7 @@ mod tests {
687687

688688
#[test]
689689
fn bonding_fails_with_wrong_denom() {
690-
let mut deps = mock_dependencies(20, &[]);
690+
let mut deps = mock_dependencies(&[]);
691691
set_validator(&mut deps.querier);
692692

693693
let creator = HumanAddr::from("creator");
@@ -715,7 +715,7 @@ mod tests {
715715

716716
#[test]
717717
fn unbonding_maintains_price_ratio() {
718-
let mut deps = mock_dependencies(20, &[]);
718+
let mut deps = mock_dependencies(&[]);
719719
set_validator(&mut deps.querier);
720720

721721
let creator = HumanAddr::from("creator");

0 commit comments

Comments
 (0)