Merge pull request #2392 from CosmWasm/rm-deprecated

Remove from_slice, from_binary, to_vec, to_binary

Author: chipshort

CHANGELOG.md

@@ -34,6 +34,8 @@ and this project adheres to
 - cosmwasm-vm: Charge gas for `write_region` ([#2378])
 - cosmwasm-vm: Remove the `cranelift` feature. This was doing nothing since
   2.2.0 already. ([#2262])
+- cosmwasm-std: Remove previously deprecated `from_slice`, `from_binary`,
+  `to_vec` and `to_binary`. ([#2156])
 
 ## Fixed
 
@@ -42,6 +44,7 @@ and this project adheres to
 - cosmwasm-vm: Fix CWA-2025-002.
 
 [#2155]: https://github.com/CosmWasm/cosmwasm/issues/2155
+[#2156]: https://github.com/CosmWasm/cosmwasm/issues/2156
 [#2262]: https://github.com/CosmWasm/cosmwasm/issues/2262
 [#2268]: https://github.com/CosmWasm/cosmwasm/issues/2268
 [#2269]: https://github.com/CosmWasm/cosmwasm/issues/2269

packages/std/src/lib.rs

@@ -111,11 +111,7 @@ pub use crate::results::{
 pub use crate::results::{DistributionMsg, StakingMsg};
 #[cfg(feature = "stargate")]
 pub use crate::results::{GovMsg, VoteOption};
-#[allow(deprecated)]
-pub use crate::serde::{
-    from_binary, from_json, from_slice, to_binary, to_json_binary, to_json_string, to_json_vec,
-    to_vec,
-};
+pub use crate::serde::{from_json, to_json_binary, to_json_string, to_json_vec};
 pub use crate::stdack::StdAck;
 pub use crate::storage::MemoryStorage;
 pub use crate::timestamp::Timestamp;

packages/std/src/results/contract_result.rs

@@ -17,19 +17,19 @@ use crate::prelude::*;
 /// Success:
 ///
 /// ```
-/// # use cosmwasm_std::{to_vec, ContractResult, Response};
+/// # use cosmwasm_std::{to_json_string, ContractResult, Response};
 /// let response: Response = Response::default();
 /// let result: ContractResult<Response> = ContractResult::Ok(response);
-/// assert_eq!(to_vec(&result).unwrap(), br#"{"ok":{"messages":[],"attributes":[],"events":[],"data":null}}"#);
+/// assert_eq!(to_json_string(&result).unwrap(), r#"{"ok":{"messages":[],"attributes":[],"events":[],"data":null}}"#);
 /// ```
 ///
 /// Failure:
 ///
 /// ```
-/// # use cosmwasm_std::{to_vec, ContractResult, Response};
+/// # use cosmwasm_std::{to_json_string, ContractResult, Response};
 /// let error_msg = String::from("Something went wrong");
 /// let result: ContractResult<Response> = ContractResult::Err(error_msg);
-/// assert_eq!(to_vec(&result).unwrap(), br#"{"error":"Something went wrong"}"#);
+/// assert_eq!(to_json_string(&result).unwrap(), r#"{"error":"Something went wrong"}"#);
 /// ```
 #[derive(Serialize, Deserialize, Clone, Debug, PartialEq, Eq, JsonSchema)]
 #[serde(rename_all = "snake_case")]

packages/std/src/results/system_result.rs

@@ -16,19 +16,19 @@ use crate::SystemError;
 /// Success:
 ///
 /// ```
-/// # use cosmwasm_std::{to_vec, Binary, ContractResult, SystemResult};
+/// # use cosmwasm_std::{to_json_string, Binary, ContractResult, SystemResult};
 /// let data = Binary::from(b"hello, world");
 /// let result = SystemResult::Ok(ContractResult::Ok(data));
-/// assert_eq!(to_vec(&result).unwrap(), br#"{"ok":{"ok":"aGVsbG8sIHdvcmxk"}}"#);
+/// assert_eq!(to_json_string(&result).unwrap(), r#"{"ok":{"ok":"aGVsbG8sIHdvcmxk"}}"#);
 /// ```
 ///
 /// Failure:
 ///
 /// ```
-/// # use cosmwasm_std::{to_vec, Binary, ContractResult, SystemResult, SystemError};
+/// # use cosmwasm_std::{to_json_string, Binary, ContractResult, SystemResult, SystemError};
 /// let error = SystemError::Unknown {};
 /// let result: SystemResult<Binary> = SystemResult::Err(error);
-/// assert_eq!(to_vec(&result).unwrap(), br#"{"error":{"unknown":{}}}"#);
+/// assert_eq!(to_json_string(&result).unwrap(), r#"{"error":{"unknown":{}}}"#);
 /// ```
 #[derive(Serialize, Deserialize, Clone, Debug, PartialEq, Eq, JsonSchema)]
 #[serde(rename_all = "snake_case")]

packages/std/src/serde.rs

@@ -9,16 +9,6 @@ use serde::{de::DeserializeOwned, Serialize};
 use crate::Binary;
 use crate::{StdError, StdResult};
 
-#[deprecated = "use from_json instead"]
-pub fn from_slice<T: DeserializeOwned>(value: &[u8]) -> StdResult<T> {
-    from_json(value)
-}
-
-#[deprecated = "use from_json instead"]
-pub fn from_binary<T: DeserializeOwned>(value: &Binary) -> StdResult<T> {
-    from_json(value)
-}
-
 /// Deserializes the given JSON bytes to a data structure.
 ///
 /// Errors if the input is not valid JSON or cannot be deserialized to the given type.
@@ -27,22 +17,6 @@ pub fn from_json<T: DeserializeOwned>(value: impl AsRef<[u8]>) -> StdResult<T> {
         .map_err(|e| StdError::parse_err(type_name::<T>(), e))
 }
 
-#[deprecated = "use to_json_vec instead"]
-pub fn to_vec<T>(data: &T) -> StdResult<Vec<u8>>
-where
-    T: Serialize + ?Sized,
-{
-    to_json_vec(data)
-}
-
-#[deprecated = "use to_json_binary instead"]
-pub fn to_binary<T>(data: &T) -> StdResult<Binary>
-where
-    T: Serialize + ?Sized,
-{
-    to_json_binary(data)
-}
-
 /// Serializes the given data structure as a JSON byte vector.
 pub fn to_json_vec<T>(data: &T) -> StdResult<Vec<u8>>
 where