Rename ::new to ::encode_json

Author: ethanfrey

contracts/ibc-reflect-send/src/ibc.rs

@@ -290,7 +290,7 @@ mod tests {
             account: account.into(),
         });
         let ack = IbcAcknowledgementWithPacket {
-            acknowledgement: IbcAcknowledgement::new(&response).unwrap(),
+            acknowledgement: IbcAcknowledgement::encode_json(&response).unwrap(),
             original_packet: mock_ibc_packet_ack(channel_id, &packet).unwrap(),
         };
         let res = ibc_packet_ack(deps, mock_env(), ack).unwrap();
@@ -381,7 +381,7 @@ mod tests {
 
         // and handle the ack
         let ack = IbcAcknowledgementWithPacket {
-            acknowledgement: IbcAcknowledgement::new(&AcknowledgementMsg::Ok(())).unwrap(),
+            acknowledgement: IbcAcknowledgement::encode_json(&AcknowledgementMsg::Ok(())).unwrap(),
             original_packet: packet,
         };
         let res = ibc_packet_ack(deps.as_mut(), mock_env(), ack).unwrap();

contracts/ibc-reflect-send/tests/integration.rs

@@ -83,7 +83,7 @@ fn who_am_i_response<T: Into<String>>(
         account: account.into(),
     });
     let ack = IbcAcknowledgementWithPacket {
-        acknowledgement: IbcAcknowledgement::new(&response).unwrap(),
+        acknowledgement: IbcAcknowledgement::encode_json(&response).unwrap(),
         original_packet: mock_ibc_packet_ack(channel_id, &packet).unwrap(),
     };
     let res: IbcBasicResponse = ibc_packet_ack(deps, mock_env(), ack).unwrap();
@@ -185,7 +185,7 @@ fn dispatch_message_send_and_ack() {
 
     // and handle the ack
     let ack = IbcAcknowledgementWithPacket {
-        acknowledgement: IbcAcknowledgement::new(&AcknowledgementMsg::Ok(())).unwrap(),
+        acknowledgement: IbcAcknowledgement::encode_json(&AcknowledgementMsg::Ok(())).unwrap(),
         original_packet: packet,
     };
     let res: IbcBasicResponse = ibc_packet_ack(&mut deps, mock_env(), ack).unwrap();

packages/std/src/ibc.rs

@@ -200,7 +200,11 @@ pub struct IbcAcknowledgement {
 }
 
 impl IbcAcknowledgement {
-    pub fn new<T: Serialize>(data: &T) -> StdResult<Self> {
+    pub fn new<T: Into<Binary>>(data: T) -> Self {
+        IbcAcknowledgement { data: data.into() }
+    }
+
+    pub fn encode_json<T: Serialize>(data: &T) -> StdResult<Self> {
         Ok(IbcAcknowledgement {
             data: to_binary(data)?,
         })