refactor(spec): modify spec to be in line with rails 6/7

- refactor RESTFul API method inside spec
- require all tables to be initialised properly before running spec
- request.session code to be updated due to point-to-reference

Author: bivanalhar

spec/controllers/posts_controller_spec.rb

@@ -1,15 +1,26 @@
 require 'rails_helper'
+require 'models'
 
 RSpec.describe PostsController, type: :controller do
   controller do
   end
 
-  before(:each) { define_first_post }
+  before(:each) do
+    @zeus = User.create!(name: 'Zeus')
+    @hera = User.create!(name: 'Hera')
+    User.stamper = @zeus
+
+    @delynn = Person.create!(name: 'Delynn')
+    @nicole = Person.create!(name: 'Nicole')
+
+    Person.stamper = @delynn
+    define_first_post
+  end
 
   context 'when updating a Post' do
     it 'sets the correct updater' do
-      request.session  = { person_id: @delynn.id }
-      post :update, id: @first_post.id, post: { title: 'Different' }
+      request.session[:person_id] = @delynn.id
+      post :update, params: { id: @first_post.id, post: { title: 'Different' } }
 
       expect(response.status).to eq(200)
       expect(controller.instance_variable_get(:@post).title).to eq('Different')
@@ -19,23 +30,23 @@
 
   context 'when handling multiple requests' do
     def simulate_second_request
-      old_request_session = request.session
-      request.session = { person_id: @nicole.id }
+      old_request_session_user_id = request.session[:person_id]
+      request.session[:person_id] = @nicole.id
 
-      post :update, id: @first_post.id, post: { title: 'Different Second'}
+      post :update, params: { id: @first_post.id, post: { title: 'Different Second'} }
       expect(controller.instance_variable_get(:@post).updater).to eq(@nicole)
     ensure
-      request.session = old_request_session
+      request.session[:person_id] = old_request_session_user_id
     end
 
     it 'sets the correct updater' do
-      request.session = { person_id: @delynn.id }
-      get :edit, id: @first_post.id
+      request.session[:person_id] = @delynn.id
+      get :edit, params: { id: @first_post.id }
       expect(response.status).to eq(200)
 
       simulate_second_request
 
-      post :update, id: @first_post.id, post: { title: 'Different' }
+      post :update, params: { id: @first_post.id, post: { title: 'Different' } }
       expect(response.status).to eq(200)
       expect(controller.instance_variable_get(:@post).title).to eq('Different')
       expect(controller.instance_variable_get(:@post).updater).to eq(@delynn)

spec/controllers/users_controller_spec.rb

@@ -1,13 +1,26 @@
 require 'rails_helper'
+require 'models'
 
 RSpec.describe UsersController, type: :controller do
   controller do
   end
 
+  before(:each) do
+    @zeus = User.create!(name: 'Zeus')
+    @hera = User.create!(name: 'Hera')
+    User.stamper = @zeus
+
+    @delynn = Person.create!(name: 'Delynn')
+    @nicole = Person.create!(name: 'Nicole')
+
+    Person.stamper = @delynn
+    define_first_post
+  end
+
   context 'when updating a User' do
     it 'sets the correct updater' do
-      request.session = { user_id: @hera.id }
-      patch :update, id: @hera.id, user: { name: 'Different'}
+      request.session[:user_id] = @hera.id
+      patch :update, params: { id: @hera.id, user: { name: 'Different'} }
 
       expect(response.status).to eq(200)
       expect(controller.instance_variable_get(:@user).name).to eq('Different')
@@ -18,17 +31,17 @@
   context 'when handling multiple requests' do
     def simulate_second_request
       old_request_session = request.session
-      request.session = { user_id: @zeus.id }
+      request.session[:user_id] = @zeus.id
 
-      post :update, id: @hera.id, user: { name: 'Different Second' }
+      post :update, params: { id: @hera.id, user: { name: 'Different Second' } }
       expect(controller.instance_variable_get(:@user).updater).to eq(@zeus)
     ensure
       request.session = old_request_session
     end
 
     it 'sets the correct updater' do
-      request.session = { user_id: @hera.id }
-      get :edit, id: @hera.id
+      request.session[:user_id] = @hera.id
+      get :edit, params: { id: @hera.id }
       expect(response.status).to eq(200)
 
       simulate_second_request
@@ -39,7 +52,7 @@ def simulate_second_request
     before { @stamper = User.stamper }
     it 'restores the correct stamper' do
       begin
-        request.session = { user_id: @zeus.id }
+        request.session[:user_id] = @zeus.id
         post :create
       rescue
       end

spec/lib/configuration_spec.rb

@@ -1,4 +1,5 @@
 require 'rails_helper'
+require 'models'
 
 RSpec.describe 'Configuration' do
   describe '.configure' do

spec/lib/migration_spec.rb

@@ -1,4 +1,5 @@
 require 'rails_helper'
+require 'models'
 
 RSpec.describe 'Migration helpers', type: :model do
   context 'when default attribute names are used' do
@@ -31,10 +32,12 @@ class self::DefaultRandom < ActiveRecord::Base
   end
 
   context 'when overridden attribute names are used' do
-    ActiveRecord::Userstamp.configure do |config|
-      config.creator_attribute = :created_by
-      config.updater_attribute = :updated_by
-      config.deleter_attribute = :deleted_by
+    before(:all) do
+      ActiveRecord::Userstamp.configure do |config|
+        config.creator_attribute = :created_by
+        config.updater_attribute = :updated_by
+        config.deleter_attribute = :deleted_by
+      end
     end
 
     class self::OverriddenRandom < ActiveRecord::Base
@@ -47,7 +50,7 @@ class self::OverriddenRandom < ActiveRecord::Base
       t.userstamps
     end
 
-    after do
+    after(:all) do
       ActiveRecord::Userstamp.configure do |config|
         config.creator_attribute = :creator_id
         config.updater_attribute = :updater_id

spec/lib/stamper_spec.rb

@@ -1,4 +1,5 @@
 require 'rails_helper'
+require 'models'
 
 RSpec.describe 'Stamper' do
   describe '.model_stamper' do

spec/lib/stamping_spec.rb

@@ -1,10 +1,17 @@
 require 'rails_helper'
+require 'models'
 
 RSpec.describe 'Stamping', type: :model do
   before(:each) do
-    define_first_post
+    @zeus = User.create!(name: 'Zeus')
+    @hera = User.create!(name: 'Hera')
     User.stamper = @zeus
+
+    @delynn = Person.create!(name: 'Delynn')
+    @nicole = Person.create!(name: 'Nicole')
+
     Person.stamper = @delynn
+    define_first_post
   end
 
   context 'when creating a Person' do