Skip to content

Commit 914bf97

Browse files
bivanalharadi-herwana-nus
authored andcommitted
fix(getHelp): allow TA to open get help from students' page
- previously, only student can use get help from his submission page - if TA, manager, or owner tried to get help from student's submission page, they will be caught in 403 permission error page
1 parent 5bc19f2 commit 914bf97

File tree

2 files changed

+7
-2
lines changed

2 files changed

+7
-2
lines changed

app/models/course/assessment/assessment_ability.rb

+7-1
Original file line numberDiff line numberDiff line change
@@ -158,6 +158,7 @@ def define_teaching_staff_assessment_permissions
158158
allow_teaching_staff_manage_assessments
159159
allow_teaching_staff_grade_assessment_submissions
160160
allow_teaching_staff_manage_assessment_annotations
161+
allow_teaching_staff_interact_with_live_feedback
161162
disallow_teaching_staff_publish_assessment_submission_grades
162163
disallow_teaching_staff_force_submit_assessment_submissions
163164
disallow_teaching_staff_delete_assessment_submissions
@@ -194,12 +195,17 @@ def allow_manage_questions
194195
end
195196

196197
def allow_teaching_staff_grade_assessment_submissions
197-
can [:update, :reload_answer, :grade, :reevaluate_answer, :generate_feedback, :fetch_submitted_feedback],
198+
can [:update, :reload_answer, :grade, :reevaluate_answer, :generate_feedback],
198199
Course::Assessment::Submission, assessment: assessment_course_hash
199200
can :grade, Course::Assessment::Answer,
200201
submission: { assessment: assessment_course_hash }
201202
end
202203

204+
def allow_teaching_staff_interact_with_live_feedback
205+
can [:generate_live_feedback, :save_live_feedback, :create_live_feedback_chat, :fetch_live_feedback_status],
206+
Course::Assessment::Submission, assessment: assessment_course_hash
207+
end
208+
203209
def allow_teaching_staff_manage_assessment_annotations
204210
can :manage, Course::Assessment::Answer::ProgrammingFileAnnotation,
205211
discussion_topic: { course_id: course.id }

config/routes.rb

-1
Original file line numberDiff line numberDiff line change
@@ -250,7 +250,6 @@
250250
post :reload_answer, on: :member
251251
post :reevaluate_answer, on: :member
252252
post :generate_feedback, on: :member
253-
get :fetch_submitted_feedback, on: :member
254253
post :generate_live_feedback, on: :member
255254
post :create_live_feedback_chat, on: :member
256255
get :fetch_live_feedback_status, on: :collection

0 commit comments

Comments
 (0)