Skip to content

Commit 231963f

Browse files
authored
Tests: enable the full test suite on Windows with newer Swift (jpsim#336)
The underlying compiler issue that was prenventing the test suite from complete execution on Windows has been resolved. Restrict the full test suite to newer versions of Swift. While technically the 11/10 snapshot should contain the fix, another issue prevents its usage. The 11/20 snapshot and newer should support the full test suite on windows as well. The Windows support should now be at complete parity with the other platforms.
1 parent 7ff7e67 commit 231963f

File tree

5 files changed

+5
-9
lines changed

5 files changed

+5
-9
lines changed

.github/workflows/swiftpm.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -84,7 +84,7 @@ jobs:
8484
tag: 5.5.1-RELEASE
8585

8686
- branch: development
87-
tag: DEVELOPMENT-SNAPSHOT-2021-06-12-a
87+
tag: DEVELOPMENT-SNAPSHOT-2021-11-20-a
8888

8989
steps:
9090
- uses: actions/checkout@v2

Tests/YamsTests/ConstructorTests.swift

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -514,8 +514,7 @@ class ConstructorTests: XCTestCase { // swiftlint:disable:this type_body_length
514514

515515
extension ConstructorTests {
516516
static var allTests: [(String, (ConstructorTests) -> () throws -> Void)] {
517-
#if os(Windows)
518-
// TODO: Fix these tests on Windows
517+
#if os(Windows) && swift(<5.6)
519518
return [
520519
("testBinary", testBinary),
521520
("testBool", testBool),

Tests/YamsTests/EncoderTests.swift

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1142,8 +1142,7 @@ private struct Unkeyed: Codable, Equatable {
11421142

11431143
extension EncoderTests {
11441144
static var allTests: [(String, (EncoderTests) -> () throws -> Void)] {
1145-
#if os(Windows)
1146-
// TODO: Fix these tests on Windows
1145+
#if os(Windows) && swift(<5.6)
11471146
return [
11481147
("testEncodingTopLevelEmptyStruct", testEncodingTopLevelEmptyStruct),
11491148
("testEncodingTopLevelEmptyClass", testEncodingTopLevelEmptyClass),

Tests/YamsTests/NodeTests.swift

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -206,8 +206,7 @@ class NodeTests: XCTestCase {
206206

207207
extension NodeTests {
208208
static var allTests: [(String, (NodeTests) -> () throws -> Void)] {
209-
#if os(Windows)
210-
// TODO: Fix these tests on Windows
209+
#if os(Windows) && swift(<5.6)
211210
return [
212211
("testExpressibleByArrayLiteral", testExpressibleByArrayLiteral),
213212
("testExpressibleByDictionaryLiteral", testExpressibleByDictionaryLiteral),

Tests/YamsTests/SpecTests.swift

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -916,8 +916,7 @@ class SpecTests: XCTestCase { // swiftlint:disable:this type_body_length
916916

917917
extension SpecTests {
918918
static var allTests: [(String, (SpecTests) -> () throws -> Void)] {
919-
#if os(Windows)
920-
// TODO: Fix these tests on Windows
919+
#if os(Windows) && swift(<5.6)
921920
return [
922921
("testEmptyString", testEmptyString),
923922
("testMultibyteCharacters", testMultibyteCharacters),

0 commit comments

Comments
 (0)