Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[1.20.1] Unable to register more than one Fan Processing Type #6111

Closed
DakotaPride opened this issue Feb 12, 2024 · 3 comments
Closed

[1.20.1] Unable to register more than one Fan Processing Type #6111

DakotaPride opened this issue Feb 12, 2024 · 3 comments
Labels
type: bug Issue where something isn't working

Comments

@DakotaPride
Copy link

DakotaPride commented Feb 12, 2024

Describe the Bug

Attempting to register two different Fan Processing Types results in a crash occurring. The crash report/latest.log files show that the "FanProcessingTypeRegistry.insertSortedType" method is at fault for the issue, from the "FanProcessingTypeRegistry.register" method.

I asked about it in the discord, but nobody could figure out why exactly the issue was happening.

If any more information needs to be provided, I'll gladly provide it, just let me know!

image image

Reproduction Steps

  1. In a development environment, attempt to register 2 or more fan processing types utilizing the base create mod registration as a reference/basis.
  2. Run the game

Expected Result

For the game to load properly with both fan processing types functioning properly.

Screenshots and Videos

No response

Crash Report or Log

https://pastebin.com/FLPJJfeF

Operating System

Windows 11

Mod Version

0.5.1e

Minecraft Version

1.20.1

Forge Version

47.1.46

Other Mods

No response

Additional Context

No response

@DakotaPride DakotaPride added the type: bug Issue where something isn't working label Feb 12, 2024
@DakotaPride
Copy link
Author

I found the issue, didn't realize that the "getPriority" method needed to be unique. I couldn't find any documentation on creating a custom fan processing type, so this might be a good idea to include considering that not a single person had noticed this.

@DakotaPride
Copy link
Author

image

@DakotaPride DakotaPride reopened this Feb 13, 2024
@VoidLeech
Copy link
Collaborator

These live in a registry now, and the offending binary search on type priority has been removed:
72d3fa6#diff-4427c5a0d0ff845f60f28f4e2d82e7f9c7f110647dd0a733fb6c4004c3b9f50eL32-L34

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: bug Issue where something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants