Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Contraptions do not produce footsteps #6118

Closed
IThundxr opened this issue Feb 15, 2024 · 2 comments · Fixed by #6446
Closed

Contraptions do not produce footsteps #6118

IThundxr opened this issue Feb 15, 2024 · 2 comments · Fixed by #6446
Labels
status: confirmed Issue's details are known, it is consistently reproducible, and it needs a fix type: bug Issue where something isn't working

Comments

@IThundxr
Copy link
Member

Describe the Bug

Happens on forge aswell even though it says its a fabric issue, ive copied the issue content from the fabric repo

Some backstory:
I was working on implementing a proper solution to generating footsteps when walking on contraptions with Presence Footsteps, but I was unable to get any sounds to play at all.

I had some success with adding a mapping to the blockmap.json to use the existing function, and removing the part that blocks sounds from coming over the network, but for some reason it only worked for other players in multiplayer and only sometimes for yourself, and wouldn't produce steps appropriate to the blocks in the contraption.

I also noticed that footsteps would also not play when PF itself was turned off, so I left it.

Then today I was looking at it again, and after working out a proper solution that integrates with Create directly... It still wouldn't play.

So I decided to just remove PF completely from the environment and test it like that.

Turns out Create's contraptions don't produce footsteps at all even with the mod loaded on its own with nothing besides Create, Mod Menu, and Quilted Fabric API. (Happens on forge aswell)

Reproduction Steps

The setup I used looks like this:

image

Without really knowing very much, I use a motor, axel, and bearing to rotate some blocks and stomped around on them in creative.

Footsteps work when walking on regular blocks, but nothing plays when walking on the rotated blocks.

Expected Result

Self explanatory

Screenshots and Videos

image

Crash Report or Log

No response

Operating System

Linux

Mod Version

0.5.1f

Minecraft Version

1.19.2

Forge Version

43.2.21

Other Mods

No response

Additional Context

Copy of Fabricators-of-Create#1169 just reported to the forge page

@Sollace
Copy link

Sollace commented Feb 15, 2024

Why was the version changed to 1.19 here? I see the original says 1.20.1

@IThundxr
Copy link
Member Author

IThundxr commented Feb 15, 2024

Why was the version changed to 1.19 here? I see the original says 1.20.1

Basically it affects all versions but I tested it on forge for 1.19, it'll have to be fixed in 1.18 since it affects that aswell and then be merged into 1.19 and 1.20

@IThundxr IThundxr added the status: confirmed Issue's details are known, it is consistently reproducible, and it needs a fix label Mar 7, 2024
IThundxr added a commit to IThundxr/Create that referenced this issue May 2, 2024
IThundxr added a commit to IThundxr/Create that referenced this issue May 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: confirmed Issue's details are known, it is consistently reproducible, and it needs a fix type: bug Issue where something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants