Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[1.18.2] Beacons below y=0 cannot turn chromatic compound into refined radiance #6148

Closed
cubebotfan opened this issue Feb 19, 2024 · 3 comments · Fixed by #6227
Closed

[1.18.2] Beacons below y=0 cannot turn chromatic compound into refined radiance #6148

cubebotfan opened this issue Feb 19, 2024 · 3 comments · Fixed by #6227
Labels
status: confirmed Issue's details are known, it is consistently reproducible, and it needs a fix type: bug Issue where something isn't working

Comments

@cubebotfan
Copy link

Describe the Bug

Chromatic compound is supposed to instantly turn into refined radiance when thrown into a beacon beam.
When the beacon producing the beam is placed below y=0, it doesn't work.

Reproduction Steps

  1. Place beacon below y=0 (with beacon base and sky exposure)
  2. Throw chromatic compound into the beacon beam
  3. Nothing happens

Expected Result

Chromatic compound is supposed to turn into refined radiance when thrown into the beacon beam

Screenshots and Videos

2024-02-19_13 16 43

Crash Report or Log

No response

Operating System

Windows 11

Mod Version

0.5.1f

Minecraft Version

1.18.2

Forge Version

40.2.17

Other Mods

Issue persists when only create is installed

Additional Context

Chromatic compound and refined radiance seem to be a hidden items by default. The modpack I'm playing unhides them. It'd be nice if the code were updated to work with the cave update since I'd imagine it only needs 1 line of code to be changed.

@cubebotfan cubebotfan added the type: bug Issue where something isn't working label Feb 19, 2024
@cubebotfan cubebotfan changed the title [1.18.2] Beacons below y=0 cannot turn cromatic compound into refined radiance [1.18.2] Beacons below y=0 cannot turn chromatic compound into refined radiance Feb 19, 2024
@drwoops
Copy link
Contributor

drwoops commented Feb 19, 2024

that is a modpack thing. you are in the wrong place

@cubebotfan
Copy link
Author

cubebotfan commented Feb 20, 2024

All the modpack does is unhide and give recipes to the refined radiance items from create

The code for the refined radiance conversion process is from create does not work with beacons in negative y coordinates.
You can test this by doing /give @s create:chromatic_compound

@IThundxr IThundxr closed this as completed Mar 8, 2024
@IThundxr IThundxr reopened this Mar 8, 2024
@IThundxr IThundxr added the status: confirmed Issue's details are known, it is consistently reproducible, and it needs a fix label Mar 8, 2024
@IThundxr
Copy link
Member

IThundxr commented Mar 8, 2024

1 line change, I'll make a PR later today

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: confirmed Issue's details are known, it is consistently reproducible, and it needs a fix type: bug Issue where something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants