Skip to content

Commit 1490cf5

Browse files
dhowellstorvalds
authored andcommitted
MN10300: Don't try and #include <linux/slab.h> in lib/inflate.c from bootloader
Don't try and #include <linux/slab.h> in lib/inflate.c from the bootloader code as linux/slab.h hauls in function defs that aren't available in the bootloader code and may also haul in conflicting functions. To fix this, make the inclusion of linux/slab.h contingent on NO_INFLATE_MALLOC as are the usages of kmalloc() and kfree(). In MN10300, this causes the following errors: In file included from include/linux/string.h:21, from include/linux/bitmap.h:8, from include/linux/nodemask.h:93, from include/linux/mmzone.h:16, from include/linux/gfp.h:4, from include/linux/slab.h:12, from arch/mn10300/boot/compressed/../../../../lib/inflate.c:106, from arch/mn10300/boot/compressed/misc.c:170: /warthog/am33/linux-2.6-mn10300/arch/mn10300/include/asm/string.h:19: error: conflicting types for 'memset' arch/mn10300/boot/compressed/misc.c:59: error: previous definition of 'memset' was here Signed-off-by: David Howells <[email protected]> Signed-off-by: Linus Torvalds <[email protected]>
1 parent 019fca8 commit 1490cf5

File tree

2 files changed

+3
-0
lines changed

2 files changed

+3
-0
lines changed

arch/mn10300/boot/compressed/misc.c

+1
Original file line numberDiff line numberDiff line change
@@ -167,6 +167,7 @@ static uch *high_buffer_start /* = (uch *)(((ulg)&end) + HEAP_SIZE)*/;
167167
static char *vidmem = (char *)0xb8000;
168168
static int lines, cols;
169169

170+
#define BOOTLOADER_INFLATE
170171
#include "../../../../lib/inflate.c"
171172

172173
static inline void scroll(void)

lib/inflate.c

+2
Original file line numberDiff line numberDiff line change
@@ -103,7 +103,9 @@
103103
the two sets of lengths.
104104
*/
105105
#include <linux/compiler.h>
106+
#ifdef NO_INFLATE_MALLOC
106107
#include <linux/slab.h>
108+
#endif
107109

108110
#ifdef RCSID
109111
static char rcsid[] = "#Id: inflate.c,v 0.14 1993/06/10 13:27:04 jloup Exp #";

0 commit comments

Comments
 (0)