Skip to content

Commit 161b6ae

Browse files
mslusarzKAGA-KOKO
authored andcommitted
debugobjects: Fix boot crash when kmemleak and debugobjects enabled
Order of initialization look like this: ... debugobjects kmemleak ...(lots of other subsystems)... workqueues (through early initcall) ... debugobjects use schedule_work for batch freeing of its data and kmemleak heavily use debugobjects, so when it comes to freeing and workqueues were not initialized yet, kernel crashes: BUG: unable to handle kernel NULL pointer dereference at (null) IP: [<ffffffff810854d1>] __queue_work+0x29/0x41a [<ffffffff81085910>] queue_work_on+0x16/0x1d [<ffffffff81085abc>] queue_work+0x29/0x55 [<ffffffff81085afb>] schedule_work+0x13/0x15 [<ffffffff81242de1>] free_object+0x90/0x95 [<ffffffff81242f6d>] debug_check_no_obj_freed+0x187/0x1d3 [<ffffffff814b6504>] ? _raw_spin_unlock_irqrestore+0x30/0x4d [<ffffffff8110bd14>] ? free_object_rcu+0x68/0x6d [<ffffffff8110890c>] kmem_cache_free+0x64/0x12c [<ffffffff8110bd14>] free_object_rcu+0x68/0x6d [<ffffffff810b58bc>] __rcu_process_callbacks+0x1b6/0x2d9 ... because system_wq is NULL. Fix it by checking if workqueues susbystem was initialized before using. Signed-off-by: Marcin Slusarz <[email protected]> Cc: Catalin Marinas <[email protected]> Cc: Tejun Heo <[email protected]> Cc: Dipankar Sarma <[email protected]> Cc: Paul E. McKenney <[email protected]> Cc: [email protected] Link: http://lkml.kernel.org/r/[email protected] Signed-off-by: Thomas Gleixner <[email protected]>
1 parent f8b7fc6 commit 161b6ae

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

lib/debugobjects.c

+1-1
Original file line numberDiff line numberDiff line change
@@ -198,7 +198,7 @@ static void free_object(struct debug_obj *obj)
198198
* initialized:
199199
*/
200200
if (obj_pool_free > ODEBUG_POOL_SIZE && obj_cache)
201-
sched = !work_pending(&debug_obj_work);
201+
sched = keventd_up() && !work_pending(&debug_obj_work);
202202
hlist_add_head(&obj->node, &obj_pool);
203203
obj_pool_free++;
204204
obj_pool_used--;

0 commit comments

Comments
 (0)