Skip to content

Commit 55ee2d3

Browse files
Wolfram SangRohan Somvanshi
Wolfram Sang
authored and
Rohan Somvanshi
committed
lib: devres: add convenience function to remap a resource
Almost every platform_driver does the three steps get_resource, request_mem_region, ioremap. This does not only lead to a lot of code duplication, but also a huge number of similar error strings and inconsistent error codes on failure. So, introduce a helper function which simplifies remapping a resource and make it hard to do something wrong and add documentation for it. Signed-off-by: Wolfram Sang <[email protected]> Acked-by: Grant Likely <[email protected]> Acked-by: Tejun Heo <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]> (cherry picked from mainline commit 72f8c0b) Change-Id: I600c5200104e234d42ca396e50853133b3ab4b1f Signed-off-by: Laxman Dewangan <[email protected]> Reviewed-on: http://git-master/r/94533 Reviewed-by: Automatic_Commit_Validation_User
1 parent f1ac572 commit 55ee2d3

File tree

3 files changed

+55
-0
lines changed

3 files changed

+55
-0
lines changed

Documentation/driver-model/devres.txt

+1
Original file line numberDiff line numberDiff line change
@@ -262,6 +262,7 @@ IOMAP
262262
devm_ioremap()
263263
devm_ioremap_nocache()
264264
devm_iounmap()
265+
devm_request_and_ioremap() : checks resource, requests region, ioremaps
265266
pcim_iomap()
266267
pcim_iounmap()
267268
pcim_iomap_table() : array of mapped addresses indexed by BAR

include/linux/device.h

+3
Original file line numberDiff line numberDiff line change
@@ -487,6 +487,9 @@ extern int devres_release_group(struct device *dev, void *id);
487487
extern void *devm_kzalloc(struct device *dev, size_t size, gfp_t gfp);
488488
extern void devm_kfree(struct device *dev, void *p);
489489

490+
void __iomem *devm_request_and_ioremap(struct device *dev,
491+
struct resource *res);
492+
490493
struct device_dma_parameters {
491494
/*
492495
* a low level driver may set these to teach IOMMU code about

lib/devres.c

+51
Original file line numberDiff line numberDiff line change
@@ -85,6 +85,57 @@ void devm_iounmap(struct device *dev, void __iomem *addr)
8585
}
8686
EXPORT_SYMBOL(devm_iounmap);
8787

88+
/**
89+
* devm_request_and_ioremap() - Check, request region, and ioremap resource
90+
* @dev: Generic device to handle the resource for
91+
* @res: resource to be handled
92+
*
93+
* Takes all necessary steps to ioremap a mem resource. Uses managed device, so
94+
* everything is undone on driver detach. Checks arguments, so you can feed
95+
* it the result from e.g. platform_get_resource() directly. Returns the
96+
* remapped pointer or NULL on error. Usage example:
97+
*
98+
* res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
99+
* base = devm_request_and_ioremap(&pdev->dev, res);
100+
* if (!base)
101+
* return -EADDRNOTAVAIL;
102+
*/
103+
void __iomem *devm_request_and_ioremap(struct device *dev,
104+
struct resource *res)
105+
{
106+
resource_size_t size;
107+
const char *name;
108+
void __iomem *dest_ptr;
109+
110+
BUG_ON(!dev);
111+
112+
if (!res || resource_type(res) != IORESOURCE_MEM) {
113+
dev_err(dev, "invalid resource\n");
114+
return NULL;
115+
}
116+
117+
size = resource_size(res);
118+
name = res->name ?: dev_name(dev);
119+
120+
if (!devm_request_mem_region(dev, res->start, size, name)) {
121+
dev_err(dev, "can't request region for resource %pR\n", res);
122+
return NULL;
123+
}
124+
125+
if (res->flags & IORESOURCE_CACHEABLE)
126+
dest_ptr = devm_ioremap(dev, res->start, size);
127+
else
128+
dest_ptr = devm_ioremap_nocache(dev, res->start, size);
129+
130+
if (!dest_ptr) {
131+
dev_err(dev, "ioremap failed for resource %pR\n", res);
132+
devm_release_mem_region(dev, res->start, size);
133+
}
134+
135+
return dest_ptr;
136+
}
137+
EXPORT_SYMBOL(devm_request_and_ioremap);
138+
88139
#ifdef CONFIG_HAS_IOPORT
89140
/*
90141
* Generic iomap devres

0 commit comments

Comments
 (0)