Skip to content

Commit 7bf02ea

Browse files
rientjestorvalds
authored andcommitted
arch, mm: filter disallowed nodes from arch specific show_mem functions
Architectures that implement their own show_mem() function did not pass the filter argument to show_free_areas() to appropriately avoid emitting the state of nodes that are disallowed in the current context. This patch now passes the filter argument to show_free_areas() so those nodes are now avoided. This patch also removes the show_free_areas() wrapper around __show_free_areas() and converts existing callers to pass an empty filter. ia64 emits additional information for each node, so skip_free_areas_zone() must be made global to filter disallowed nodes and it is converted to use a nid argument rather than a zone for this use case. Signed-off-by: David Rientjes <[email protected]> Cc: Russell King <[email protected]> Cc: Tony Luck <[email protected]> Cc: Fenghua Yu <[email protected]> Cc: Kyle McMartin <[email protected]> Cc: Helge Deller <[email protected]> Cc: James Bottomley <[email protected]> Cc: "David S. Miller" <[email protected]> Cc: Guan Xuetao <[email protected]> Signed-off-by: Andrew Morton <[email protected]> Signed-off-by: Linus Torvalds <[email protected]>
1 parent 851cc85 commit 7bf02ea

File tree

13 files changed

+34
-36
lines changed

13 files changed

+34
-36
lines changed

arch/arm/mm/init.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -85,7 +85,7 @@ void show_mem(unsigned int filter)
8585
struct meminfo * mi = &meminfo;
8686

8787
printk("Mem-info:\n");
88-
show_free_areas();
88+
show_free_areas(filter);
8989

9090
for_each_bank (i, mi) {
9191
struct membank *bank = &mi->bank[i];

arch/ia64/mm/contig.c

Lines changed: 6 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -44,13 +44,16 @@ void show_mem(unsigned int filter)
4444
pg_data_t *pgdat;
4545

4646
printk(KERN_INFO "Mem-info:\n");
47-
show_free_areas();
47+
show_free_areas(filter);
4848
printk(KERN_INFO "Node memory in pages:\n");
4949
for_each_online_pgdat(pgdat) {
5050
unsigned long present;
5151
unsigned long flags;
5252
int shared = 0, cached = 0, reserved = 0;
53+
int nid = pgdat->node_id;
5354

55+
if (skip_free_areas_node(filter, nid))
56+
continue;
5457
pgdat_resize_lock(pgdat, &flags);
5558
present = pgdat->node_present_pages;
5659
for(i = 0; i < pgdat->node_spanned_pages; i++) {
@@ -64,8 +67,7 @@ void show_mem(unsigned int filter)
6467
if (max_gap < LARGE_GAP)
6568
continue;
6669
#endif
67-
i = vmemmap_find_next_valid_pfn(pgdat->node_id,
68-
i) - 1;
70+
i = vmemmap_find_next_valid_pfn(nid, i) - 1;
6971
continue;
7072
}
7173
if (PageReserved(page))
@@ -81,7 +83,7 @@ void show_mem(unsigned int filter)
8183
total_cached += cached;
8284
total_shared += shared;
8385
printk(KERN_INFO "Node %4d: RAM: %11ld, rsvd: %8d, "
84-
"shrd: %10d, swpd: %10d\n", pgdat->node_id,
86+
"shrd: %10d, swpd: %10d\n", nid,
8587
present, reserved, shared, cached);
8688
}
8789
printk(KERN_INFO "%ld pages of RAM\n", total_present);

arch/ia64/mm/discontig.c

Lines changed: 6 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -622,13 +622,16 @@ void show_mem(unsigned int filter)
622622
pg_data_t *pgdat;
623623

624624
printk(KERN_INFO "Mem-info:\n");
625-
show_free_areas();
625+
show_free_areas(filter);
626626
printk(KERN_INFO "Node memory in pages:\n");
627627
for_each_online_pgdat(pgdat) {
628628
unsigned long present;
629629
unsigned long flags;
630630
int shared = 0, cached = 0, reserved = 0;
631+
int nid = pgdat->node_id;
631632

633+
if (skip_free_areas_node(filter, nid))
634+
continue;
632635
pgdat_resize_lock(pgdat, &flags);
633636
present = pgdat->node_present_pages;
634637
for(i = 0; i < pgdat->node_spanned_pages; i++) {
@@ -638,8 +641,7 @@ void show_mem(unsigned int filter)
638641
if (pfn_valid(pgdat->node_start_pfn + i))
639642
page = pfn_to_page(pgdat->node_start_pfn + i);
640643
else {
641-
i = vmemmap_find_next_valid_pfn(pgdat->node_id,
642-
i) - 1;
644+
i = vmemmap_find_next_valid_pfn(nid, i) - 1;
643645
continue;
644646
}
645647
if (PageReserved(page))
@@ -655,7 +657,7 @@ void show_mem(unsigned int filter)
655657
total_cached += cached;
656658
total_shared += shared;
657659
printk(KERN_INFO "Node %4d: RAM: %11ld, rsvd: %8d, "
658-
"shrd: %10d, swpd: %10d\n", pgdat->node_id,
660+
"shrd: %10d, swpd: %10d\n", nid,
659661
present, reserved, shared, cached);
660662
}
661663
printk(KERN_INFO "%ld pages of RAM\n", total_present);

arch/parisc/mm/init.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -686,7 +686,7 @@ void show_mem(unsigned int filter)
686686
int shared = 0, cached = 0;
687687

688688
printk(KERN_INFO "Mem-info:\n");
689-
show_free_areas();
689+
show_free_areas(filter);
690690
#ifndef CONFIG_DISCONTIGMEM
691691
i = max_mapnr;
692692
while (i-- > 0) {

arch/sparc/kernel/setup_32.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -82,7 +82,7 @@ static void prom_sync_me(void)
8282
"nop\n\t" : : "r" (&trapbase));
8383

8484
prom_printf("PROM SYNC COMMAND...\n");
85-
show_free_areas();
85+
show_free_areas(0);
8686
if(current->pid != 0) {
8787
local_irq_enable();
8888
sys_sync();

arch/sparc/mm/init_32.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -78,7 +78,7 @@ void __init kmap_init(void)
7878
void show_mem(unsigned int filter)
7979
{
8080
printk("Mem-info:\n");
81-
show_free_areas();
81+
show_free_areas(filter);
8282
printk("Free swap: %6ldkB\n",
8383
nr_swap_pages << (PAGE_SHIFT-10));
8484
printk("%ld pages of RAM\n", totalram_pages);

arch/unicore32/mm/init.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -62,7 +62,7 @@ void show_mem(unsigned int filter)
6262
struct meminfo *mi = &meminfo;
6363

6464
printk(KERN_DEFAULT "Mem-info:\n");
65-
show_free_areas();
65+
show_free_areas(filter);
6666

6767
for_each_bank(i, mi) {
6868
struct membank *bank = &mi->bank[i];

drivers/net/ioc3-eth.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -915,7 +915,7 @@ static void ioc3_alloc_rings(struct net_device *dev)
915915

916916
skb = ioc3_alloc_skb(RX_BUF_ALLOC_SIZE, GFP_ATOMIC);
917917
if (!skb) {
918-
show_free_areas();
918+
show_free_areas(0);
919919
continue;
920920
}
921921

drivers/tty/serial/68328serial.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -281,7 +281,7 @@ static void receive_chars(struct m68k_serial *info, unsigned short rx)
281281
#ifdef CONFIG_MAGIC_SYSRQ
282282
} else if (ch == 0x10) { /* ^P */
283283
show_state();
284-
show_free_areas();
284+
show_free_areas(0);
285285
show_buffers();
286286
/* show_net_buffers(); */
287287
return;

include/linux/mm.h

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -862,13 +862,13 @@ extern void pagefault_out_of_memory(void);
862862
#define offset_in_page(p) ((unsigned long)(p) & ~PAGE_MASK)
863863

864864
/*
865-
* Flags passed to show_mem() and __show_free_areas() to suppress output in
865+
* Flags passed to show_mem() and show_free_areas() to suppress output in
866866
* various contexts.
867867
*/
868868
#define SHOW_MEM_FILTER_NODES (0x0001u) /* filter disallowed nodes */
869869

870-
extern void show_free_areas(void);
871-
extern void __show_free_areas(unsigned int flags);
870+
extern void show_free_areas(unsigned int flags);
871+
extern bool skip_free_areas_node(unsigned int flags, int nid);
872872

873873
int shmem_lock(struct file *file, int lock, struct user_struct *user);
874874
struct file *shmem_file_setup(const char *name, loff_t size, unsigned long flags);

0 commit comments

Comments
 (0)