Skip to content

Commit 8ad6a56

Browse files
taoma-tmJens Axboe
authored andcommitted
block: Don't check QUEUE_FLAG_SAME_COMP in __blk_complete_request
In __blk_complete_request, we check both QUEUE_FLAG_SAME_COMP and req->cpu to decide whether we should use req->cpu. Actually the user can also select the complete cpu by either setting BIO_CPU_AFFINE or by calling bio_set_completion_cpu. Current solution makes these 2 ways don't work any more. So we'd better just check req->cpu. Signed-off-by: Tao Ma <[email protected]> Signed-off-by: Jens Axboe <[email protected]>
1 parent 09f40f9 commit 8ad6a56

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

block/blk-softirq.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -115,7 +115,7 @@ void __blk_complete_request(struct request *req)
115115
/*
116116
* Select completion CPU
117117
*/
118-
if (test_bit(QUEUE_FLAG_SAME_COMP, &q->queue_flags) && req->cpu != -1) {
118+
if (req->cpu != -1) {
119119
ccpu = req->cpu;
120120
if (!test_bit(QUEUE_FLAG_SAME_FORCE, &q->queue_flags)) {
121121
ccpu = blk_cpu_to_group(ccpu);

0 commit comments

Comments
 (0)